mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr
@ 2021-12-13 18:56 Colin Ian King
  2023-02-26  2:09 ` Matt Turner
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-12-13 18:56 UTC (permalink / raw)
  To: Richard Henderson, Ivan Kokshaysky, linux-alpha
  Cc: kernel-janitors, linux-kernel

Calling the osf_mount system call with an invalid typenr value will
spam the kernel log with error messages. Reduce the spamming by making
it a ratelimited printk.  Issue found when exercising with the stress-ng
enosys system call stressor.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 arch/alpha/kernel/osf_sys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index 8bbeebb73cf0..2367a385d726 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -521,7 +521,7 @@ SYSCALL_DEFINE4(osf_mount, unsigned long, typenr, const char __user *, path,
 		break;
 	default:
 		retval = -EINVAL;
-		printk("osf_mount(%ld, %x)\n", typenr, flag);
+		printk_ratelimited("osf_mount(%ld, %x)\n", typenr, flag);
 	}
 
 	return retval;
-- 
2.33.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr
  2021-12-13 18:56 [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr Colin Ian King
@ 2023-02-26  2:09 ` Matt Turner
  0 siblings, 0 replies; 2+ messages in thread
From: Matt Turner @ 2023-02-26  2:09 UTC (permalink / raw)
  To: Colin Ian King
  Cc: Richard Henderson, Ivan Kokshaysky, linux-alpha, kernel-janitors,
	linux-kernel

On Mon, Dec 13, 2021 at 10:58 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> Calling the osf_mount system call with an invalid typenr value will
> spam the kernel log with error messages. Reduce the spamming by making
> it a ratelimited printk.  Issue found when exercising with the stress-ng
> enosys system call stressor.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  arch/alpha/kernel/osf_sys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
> index 8bbeebb73cf0..2367a385d726 100644
> --- a/arch/alpha/kernel/osf_sys.c
> +++ b/arch/alpha/kernel/osf_sys.c
> @@ -521,7 +521,7 @@ SYSCALL_DEFINE4(osf_mount, unsigned long, typenr, const char __user *, path,
>                 break;
>         default:
>                 retval = -EINVAL;
> -               printk("osf_mount(%ld, %x)\n", typenr, flag);
> +               printk_ratelimited("osf_mount(%ld, %x)\n", typenr, flag);
>         }
>
>         return retval;
> --
> 2.33.1
>

Thanks for the patch! This was included in my pull request today and
is now upstream in Linus' tree.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-26  2:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 18:56 [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr Colin Ian King
2023-02-26  2:09 ` Matt Turner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®