* [PATCH] drm/amd/display: Fix warning comparing pointer to 0
@ 2021-12-16 7:50 Jiapeng Chong
2021-12-16 15:20 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Jiapeng Chong @ 2021-12-16 7:50 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
Fix the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c:744:35-36:
WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c
index 8f78e62b28b7..48005def1164 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c
@@ -741,7 +741,7 @@ void vg_clk_mgr_construct(
sizeof(struct watermarks),
&clk_mgr->smu_wm_set.mc_address.quad_part);
- if (clk_mgr->smu_wm_set.wm_set == 0) {
+ if (!clk_mgr->smu_wm_set.wm_set) {
clk_mgr->smu_wm_set.wm_set = &dummy_wms;
clk_mgr->smu_wm_set.mc_address.quad_part = 0;
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0
2021-12-16 7:50 [PATCH] drm/amd/display: Fix warning comparing pointer to 0 Jiapeng Chong
@ 2021-12-16 15:20 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2021-12-16 15:20 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Wentland, Harry, Leo (Sunpeng) Li, Abaci Robot, xinhui pan,
Siqueira, Rodrigo, LKML, amd-gfx list, Dave Airlie,
Maling list - DRI developers, Deucher, Alexander,
Christian Koenig
Applied. Thanks!
Alex
On Thu, Dec 16, 2021 at 2:50 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c:744:35-36:
> WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c
> index 8f78e62b28b7..48005def1164 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c
> @@ -741,7 +741,7 @@ void vg_clk_mgr_construct(
> sizeof(struct watermarks),
> &clk_mgr->smu_wm_set.mc_address.quad_part);
>
> - if (clk_mgr->smu_wm_set.wm_set == 0) {
> + if (!clk_mgr->smu_wm_set.wm_set) {
> clk_mgr->smu_wm_set.wm_set = &dummy_wms;
> clk_mgr->smu_wm_set.mc_address.quad_part = 0;
> }
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/amd/display: Fix warning comparing pointer to 0
@ 2023-12-01 9:30 Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2023-12-01 9:30 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
Avoid pointer type value compared with 0 to make code clear.
./drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c:532:62-63: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7672
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
index 38360adc53d9..7d13d2e1bda8 100644
--- a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c
@@ -529,7 +529,7 @@ enum dmub_status dmub_srv_calc_mem_info(struct dmub_srv *dmub,
out->fb[i].cpu_addr = cpu_base + reg->base;
out->fb[i].gpu_addr = gpu_base + reg->base;
- if (i == DMUB_WINDOW_4_MAILBOX && params->cpu_inbox_addr != 0) {
+ if (i == DMUB_WINDOW_4_MAILBOX && params->cpu_inbox_addr) {
out->fb[i].cpu_addr = (uint8_t *)params->cpu_inbox_addr + reg->base;
out->fb[i].gpu_addr = params->gpu_inbox_addr + reg->base;
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] drm/amd/display: Fix warning comparing pointer to 0
@ 2021-11-24 10:20 Jiapeng Chong
2021-11-24 19:40 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 8+ messages in thread
From: Jiapeng Chong @ 2021-11-24 10:20 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong
Fix the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING
comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
index 122ba29..ec636d0 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
@@ -93,7 +93,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc,
TABLE_CASE(420, 12, min);
}
- if (table == 0)
+ if (!table)
return;
index = (bpp - table[0].bpp) * 2;
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0
2021-11-24 10:20 Jiapeng Chong
@ 2021-11-24 19:40 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Siqueira Jordao @ 2021-11-24 19:40 UTC (permalink / raw)
To: Jiapeng Chong, harry.wentland
Cc: sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel
On 2021-11-24 5:20 a.m., Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c:96:14-15: WARNING
> comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
> index 122ba29..ec636d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dsc/rc_calc_fpu.c
> @@ -93,7 +93,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc,
> TABLE_CASE(420, 12, min);
> }
>
> - if (table == 0)
> + if (!table)
> return;
>
> index = (bpp - table[0].bpp) * 2;
>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Applied to amd-staging-drm-next
Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/amd/display: Fix warning comparing pointer to 0
@ 2021-09-06 9:23 Jiapeng Chong
2021-09-07 17:07 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Jiapeng Chong @ 2021-09-06 9:23 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, alexander.deucher, christian.koenig, Xinhui.Pan,
airlied, daniel, amd-gfx, dri-devel, linux-kernel, chongjiapeng
From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
Fix the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:643:35-36:
WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
index 4a4894e..15491e3 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
@@ -640,7 +640,7 @@ void dcn31_clk_mgr_construct(
sizeof(struct dcn31_watermarks),
&clk_mgr->smu_wm_set.mc_address.quad_part);
- if (clk_mgr->smu_wm_set.wm_set == 0) {
+ if (!clk_mgr->smu_wm_set.wm_set) {
clk_mgr->smu_wm_set.wm_set = &dummy_wms;
clk_mgr->smu_wm_set.mc_address.quad_part = 0;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amd/display: Fix warning comparing pointer to 0
2021-09-06 9:23 Jiapeng Chong
@ 2021-09-07 17:07 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2021-09-07 17:07 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Wentland, Harry, Leo (Sunpeng) Li, Deucher, Alexander,
Christian Koenig, xinhui pan, Dave Airlie, Daniel Vetter,
amd-gfx list, Maling list - DRI developers, LKML
Applied. Thanks!
Alex
On Mon, Sep 6, 2021 at 5:23 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c:643:35-36:
> WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
> index 4a4894e..15491e3 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c
> @@ -640,7 +640,7 @@ void dcn31_clk_mgr_construct(
> sizeof(struct dcn31_watermarks),
> &clk_mgr->smu_wm_set.mc_address.quad_part);
>
> - if (clk_mgr->smu_wm_set.wm_set == 0) {
> + if (!clk_mgr->smu_wm_set.wm_set) {
> clk_mgr->smu_wm_set.wm_set = &dummy_wms;
> clk_mgr->smu_wm_set.mc_address.quad_part = 0;
> }
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/amd/display: fix warning comparing pointer to 0
@ 2021-03-10 7:04 Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2021-03-10 7:04 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, alexander.deucher, christian.koenig, airlied, daniel,
amd-gfx, dri-devel, linux-kernel, Jiapeng Chong
Fix the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c:76:14-15: WARNING
comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c b/drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c
index c6a1cd8..69211f5 100644
--- a/drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c
+++ b/drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c
@@ -73,7 +73,7 @@ static void get_qp_set(qp_set qps, enum colour_mode cm, enum bits_per_comp bpc,
TABLE_CASE(420, 12, min);
}
- if (table == 0)
+ if (!table)
return;
index = (bpp - table[0].bpp) * 2;
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-01 9:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 7:50 [PATCH] drm/amd/display: Fix warning comparing pointer to 0 Jiapeng Chong
2021-12-16 15:20 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-12-01 9:30 Jiapeng Chong
2021-11-24 10:20 Jiapeng Chong
2021-11-24 19:40 ` Rodrigo Siqueira Jordao
2021-09-06 9:23 Jiapeng Chong
2021-09-07 17:07 ` Alex Deucher
2021-03-10 7:04 [PATCH] drm/amd/display: fix " Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®