* [PATCH] rcu/nocb: clean up some inconsistent indenting
@ 2021-12-16 9:10 Jiapeng Chong
2021-12-16 15:26 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-12-16 9:10 UTC (permalink / raw)
To: paulmck
Cc: frederic, quic_neeraju, josh, rostedt, mathieu.desnoyers,
jiangshanlai, joel, rcu, linux-kernel, Jiapeng Chong,
Abaci Robot
Eliminate the follow smatch warning:
kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn:
inconsistent indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/rcu/tree_nocb.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h
index dd4753219dca..936badfffcee 100644
--- a/kernel/rcu/tree_nocb.h
+++ b/kernel/rcu/tree_nocb.h
@@ -1259,7 +1259,8 @@ static void rcu_spawn_cpu_nocb_kthread(int cpu)
}
WRITE_ONCE(rdp_gp->nocb_gp_kthread, t);
}
- mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
+
+ mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
/* Spawn the kthread for this CPU. */
t = kthread_run(rcu_nocb_cb_kthread, rdp,
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu/nocb: clean up some inconsistent indenting
2021-12-16 9:10 [PATCH] rcu/nocb: clean up some inconsistent indenting Jiapeng Chong
@ 2021-12-16 15:26 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2021-12-16 15:26 UTC (permalink / raw)
To: Jiapeng Chong
Cc: frederic, quic_neeraju, josh, rostedt, mathieu.desnoyers,
jiangshanlai, joel, rcu, linux-kernel, Abaci Robot
On Thu, Dec 16, 2021 at 05:10:57PM +0800, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Good catch, but kernel test robot beat you to it:
7512661668d7 ("rcu/nocb: Handle concurrent nocb kthreads creation")
Thanx, Paul
> ---
> kernel/rcu/tree_nocb.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h
> index dd4753219dca..936badfffcee 100644
> --- a/kernel/rcu/tree_nocb.h
> +++ b/kernel/rcu/tree_nocb.h
> @@ -1259,7 +1259,8 @@ static void rcu_spawn_cpu_nocb_kthread(int cpu)
> }
> WRITE_ONCE(rdp_gp->nocb_gp_kthread, t);
> }
> - mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
> +
> + mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
>
> /* Spawn the kthread for this CPU. */
> t = kthread_run(rcu_nocb_cb_kthread, rdp,
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 9:10 [PATCH] rcu/nocb: clean up some inconsistent indenting Jiapeng Chong
2021-12-16 15:26 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®