From: Guenter Roeck <linux@roeck-us.net>
To: Arseny Demidov <arsdemal@gmail.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>,
rahul.tanwar@linux.intel.com, andriy.shevchenko@intel.com,
Arseny Demidov <a.demidov@yadro.com>
Subject: Re: [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value
Date: Mon, 20 Dec 2021 13:03:11 -0800 [thread overview]
Message-ID: <20211220210311.GA194769@roeck-us.net> (raw)
In-Reply-To: <20211219102239.1112-1-a.demidov@yadro.com>
On Sun, Dec 19, 2021 at 01:22:39PM +0300, Arseny Demidov wrote:
> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
> the correct value should be 0x100. The register ip_tmr is expressed
> in units of IP clk cycles, in accordance with the datasheet.
> Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
>
> Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for Moortec MR75203 PVT controller")
> Signed-off-by: Arseny Demidov <a.demidov@yadro.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/mr75203.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 868243dba1ee..1ba1e3145969 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -93,7 +93,7 @@
> #define VM_CH_REQ BIT(21)
>
> #define IP_TMR 0x05
> -#define POWER_DELAY_CYCLE_256 0x80
> +#define POWER_DELAY_CYCLE_256 0x100
> #define POWER_DELAY_CYCLE_64 0x40
>
> #define PVT_POLL_DELAY_US 20
prev parent reply other threads:[~2021-12-20 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-19 10:22 Arseny Demidov
2021-12-20 21:03 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220210311.GA194769@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.demidov@yadro.com \
--cc=andriy.shevchenko@intel.com \
--cc=arsdemal@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rahul.tanwar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®