* [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value
@ 2021-12-19 10:22 Arseny Demidov
2021-12-20 21:03 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arseny Demidov @ 2021-12-19 10:22 UTC (permalink / raw)
To: linux-hwmon, linux-kernel
Cc: Jean Delvare, Guenter Roeck, rahul.tanwar, andriy.shevchenko,
Arseny Demidov
In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
the correct value should be 0x100. The register ip_tmr is expressed
in units of IP clk cycles, in accordance with the datasheet.
Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for Moortec MR75203 PVT controller")
Signed-off-by: Arseny Demidov <a.demidov@yadro.com>
---
drivers/hwmon/mr75203.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
index 868243dba1ee..1ba1e3145969 100644
--- a/drivers/hwmon/mr75203.c
+++ b/drivers/hwmon/mr75203.c
@@ -93,7 +93,7 @@
#define VM_CH_REQ BIT(21)
#define IP_TMR 0x05
-#define POWER_DELAY_CYCLE_256 0x80
+#define POWER_DELAY_CYCLE_256 0x100
#define POWER_DELAY_CYCLE_64 0x40
#define PVT_POLL_DELAY_US 20
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value
2021-12-19 10:22 [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value Arseny Demidov
@ 2021-12-20 21:03 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-12-20 21:03 UTC (permalink / raw)
To: Arseny Demidov
Cc: linux-hwmon, linux-kernel, Jean Delvare, rahul.tanwar,
andriy.shevchenko, Arseny Demidov
On Sun, Dec 19, 2021 at 01:22:39PM +0300, Arseny Demidov wrote:
> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
> the correct value should be 0x100. The register ip_tmr is expressed
> in units of IP clk cycles, in accordance with the datasheet.
> Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
>
> Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for Moortec MR75203 PVT controller")
> Signed-off-by: Arseny Demidov <a.demidov@yadro.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/mr75203.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 868243dba1ee..1ba1e3145969 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -93,7 +93,7 @@
> #define VM_CH_REQ BIT(21)
>
> #define IP_TMR 0x05
> -#define POWER_DELAY_CYCLE_256 0x80
> +#define POWER_DELAY_CYCLE_256 0x100
> #define POWER_DELAY_CYCLE_64 0x40
>
> #define PVT_POLL_DELAY_US 20
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-20 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-19 10:22 [PATCH v1 1/1] hwmon : (mr75203) fix wrong power-up delay value Arseny Demidov
2021-12-20 21:03 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®