mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, H Peter Anvin <hpa@zytor.com>,
	chang.seok.bae@intel.com
Subject: Re: [PATCH 0/6] x86/insn: Add instructions to instruction decoder
Date: Thu, 23 Dec 2021 15:38:08 +0900	[thread overview]
Message-ID: <20211223153808.cddab56b114e5ddf755bd2d0@kernel.org> (raw)
In-Reply-To: <20211202095029.2165714-1-adrian.hunter@intel.com>

Hi,

Sorry, I missed this series.

On Thu,  2 Dec 2021 11:50:23 +0200
Adrian Hunter <adrian.hunter@intel.com> wrote:

> Hi
> 
> Here are patches to bring the kernel and tools x86 instruction decoder
> more up to date.
> 
> x86 instruction decoder is used for both kernel instructions and user space
> instructions (e.g. uprobes, perf tools Intel PT), so it is good to update
> it with new instructions.

Hmm, I thought perf used objdump for that purpose internally.
Anyway, this series looks good to me. I'm a bit surprised that the
insn decoder can actually support those instructions only changing
X86_EVEX_M() macro :-)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you!

> 
> 
> Adrian Hunter (6):
>       perf tests: Add AMX instructions to x86 instruction decoder test
>       x86/insn: Add AMX instructions to x86 instruction decoder
>       perf tests: Add misc instructions to x86 instruction decoder test
>       x86/insn: Add misc instructions to x86 instruction decoder
>       perf tests: Add AVX512-FP16 instructions to x86 instruction decoder test
>       x86/insn: Add AVX512-FP16 instructions to x86 instruction decoder
> 
>  arch/x86/include/asm/insn.h                  |    2 +-
>  arch/x86/lib/x86-opcode-map.txt              |  111 +-
>  tools/arch/x86/include/asm/insn.h            |    2 +-
>  tools/arch/x86/lib/x86-opcode-map.txt        |  111 +-
>  tools/perf/arch/x86/tests/insn-x86-dat-32.c  |  918 +++++++++++++++++
>  tools/perf/arch/x86/tests/insn-x86-dat-64.c  | 1426 ++++++++++++++++++++++++++
>  tools/perf/arch/x86/tests/insn-x86-dat-src.c | 1189 +++++++++++++++++++++
>  7 files changed, 3731 insertions(+), 28 deletions(-)
> 
> 
> Regards
> Adrian


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  parent reply	other threads:[~2021-12-23  6:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  9:50 Adrian Hunter
2021-12-02  9:50 ` [PATCH 1/6] perf tests: Add AMX instructions to x86 instruction decoder test Adrian Hunter
2022-01-23 19:44   ` [tip: x86/misc] perf/tests: " tip-bot2 for Adrian Hunter
2021-12-02  9:50 ` [PATCH 2/6] x86/insn: Add AMX instructions to x86 instruction decoder Adrian Hunter
2022-01-23 19:44   ` [tip: x86/misc] x86/insn: Add AMX instructions to the " tip-bot2 for Adrian Hunter
2021-12-02  9:50 ` [PATCH 3/6] perf tests: Add misc instructions to x86 instruction decoder test Adrian Hunter
2022-01-23 19:44   ` [tip: x86/misc] perf/tests: Add misc instructions to the " tip-bot2 for Adrian Hunter
2021-12-02  9:50 ` [PATCH 4/6] x86/insn: Add misc instructions to x86 instruction decoder Adrian Hunter
2022-01-23 19:44   ` [tip: x86/misc] " tip-bot2 for Adrian Hunter
2021-12-02  9:50 ` [PATCH 5/6] perf tests: Add AVX512-FP16 instructions to x86 instruction decoder test Adrian Hunter
2022-01-23 19:44   ` [tip: x86/misc] perf/tests: " tip-bot2 for Adrian Hunter
2021-12-02  9:50 ` [PATCH 6/6] x86/insn: Add AVX512-FP16 instructions to x86 instruction decoder Adrian Hunter
2022-01-23 19:44   ` [tip: x86/misc] x86/insn: Add AVX512-FP16 instructions to the " tip-bot2 for Adrian Hunter
2021-12-23  6:38 ` Masami Hiramatsu [this message]
2022-01-03  8:13   ` [PATCH 0/6] x86/insn: Add instructions to " Adrian Hunter
2022-01-03 14:56     ` Arnaldo Carvalho de Melo
2022-01-03 15:01       ` Arnaldo Carvalho de Melo
2022-01-03 15:40         ` Adrian Hunter
2022-01-03 18:22           ` Arnaldo Carvalho de Melo
2022-01-03 18:30             ` Arnaldo Carvalho de Melo
2022-01-13  6:52               ` Adrian Hunter
2022-01-13 10:16                 ` Borislav Petkov
2022-01-13 10:33                   ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211223153808.cddab56b114e5ddf755bd2d0@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome