From: Wang ShaoBo <bobo.shaobowang@huawei.com>
To: <rostedt@goodmis.org>
Cc: <xiexiuqi@huawei.com>, <cj.chengjian@huawei.com>,
<liwei391@huawei.com>, <bristot@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] tracing/osnoise: Fix sparse warning in function start_kthread
Date: Tue, 4 Jan 2022 17:48:29 +0800 [thread overview]
Message-ID: <20220104094829.334872-1-bobo.shaobowang@huawei.com> (raw)
Change main to main_func to fix following sparse warning:
kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
kernel/trace/trace_osnoise.c:1674:8: warning: ‘main’ is usually a function [-Wmain]
void *main = osnoise_main;
^~~~
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
kernel/trace/trace_osnoise.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
index 7520d43aed55..2bebf31d4baf 100644
--- a/kernel/trace/trace_osnoise.c
+++ b/kernel/trace/trace_osnoise.c
@@ -1691,17 +1691,17 @@ static void stop_per_cpu_kthreads(void)
static int start_kthread(unsigned int cpu)
{
struct task_struct *kthread;
- void *main = osnoise_main;
+ void *main_func = osnoise_main;
char comm[24];
if (timerlat_enabled()) {
snprintf(comm, 24, "timerlat/%d", cpu);
- main = timerlat_main;
+ main_func = timerlat_main;
} else {
snprintf(comm, 24, "osnoise/%d", cpu);
}
- kthread = kthread_create_on_cpu(main, NULL, cpu, comm);
+ kthread = kthread_create_on_cpu(main_func, NULL, cpu, comm);
if (IS_ERR(kthread)) {
pr_err(BANNER "could not start sampling thread\n");
--
2.25.1
next reply other threads:[~2022-01-04 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 9:48 Wang ShaoBo [this message]
2022-01-04 10:12 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220104094829.334872-1-bobo.shaobowang@huawei.com \
--to=bobo.shaobowang@huawei.com \
--cc=bristot@kernel.org \
--cc=cj.chengjian@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=rostedt@goodmis.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®