From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Wang ShaoBo <bobo.shaobowang@huawei.com>, rostedt@goodmis.org
Cc: xiexiuqi@huawei.com, cj.chengjian@huawei.com,
liwei391@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/osnoise: Fix sparse warning in function start_kthread
Date: Tue, 4 Jan 2022 11:12:15 +0100 [thread overview]
Message-ID: <de6126fb-68db-7369-a14a-1172f0899e91@kernel.org> (raw)
In-Reply-To: <20220104094829.334872-1-bobo.shaobowang@huawei.com>
On 1/4/22 10:48, Wang ShaoBo wrote:
> Change main to main_func to fix following sparse warning:
>
> kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
> kernel/trace/trace_osnoise.c:1674:8: warning: ‘main’ is usually a function [-Wmain]
> void *main = osnoise_main;
> ^~~~
NAK!
This was already discussed... many times. The problem is not in the usage of
main as a variable name but in the tool that you are using. Try to fix your tool.
E.g., https://lore.kernel.org/lkml/20210813224131.25803-1-rdunlap@infradead.org/
-- Daniel
prev parent reply other threads:[~2022-01-04 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 9:48 Wang ShaoBo
2022-01-04 10:12 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de6126fb-68db-7369-a14a-1172f0899e91@kernel.org \
--to=bristot@kernel.org \
--cc=bobo.shaobowang@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=rostedt@goodmis.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®