* [PATCH] drivers/scsi: remove redundant error variable
@ 2022-01-04 11:24 cgel.zte
2022-01-10 22:04 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-01-04 11:24 UTC (permalink / raw)
To: hare
Cc: jejb, martin.petersen, linux-scsi, linux-kernel, Minghao Chi,
Zeal Robot, CGEL ZTE
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from ahd_linux_queue_abort_cmd() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/scsi/aic7xxx/aic79xx_osm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
index 5d566d2b2997..928099163f0f 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -755,11 +755,7 @@ ahd_linux_biosparam(struct scsi_device *sdev, struct block_device *bdev,
static int
ahd_linux_abort(struct scsi_cmnd *cmd)
{
- int error;
-
- error = ahd_linux_queue_abort_cmd(cmd);
-
- return error;
+ return ahd_linux_queue_abort_cmd(cmd);
}
/*
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/scsi: remove redundant error variable
2022-01-04 11:24 [PATCH] drivers/scsi: remove redundant error variable cgel.zte
@ 2022-01-10 22:04 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-01-10 22:04 UTC (permalink / raw)
To: hare, cgel.zte
Cc: Martin K . Petersen, linux-scsi, jejb, Zeal Robot, linux-kernel,
Minghao Chi
On Tue, 4 Jan 2022 11:24:52 +0000, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from ahd_linux_queue_abort_cmd() directly instead
> of taking this in another redundant variable.
>
>
Applied to 5.17/scsi-queue, thanks!
[1/1] drivers/scsi: remove redundant error variable
https://git.kernel.org/mkp/scsi/c/c3b48443ba7c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-10 22:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 11:24 [PATCH] drivers/scsi: remove redundant error variable cgel.zte
2022-01-10 22:04 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®