* [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends
@ 2022-01-05 9:41 William Breathitt Gray
2022-01-09 21:22 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: William Breathitt Gray @ 2022-01-05 9:41 UTC (permalink / raw)
To: Jonathan.Cameron
Cc: linux-iio, linux-kernel, u.kleine-koenig, William Breathitt Gray,
Syed Nayyar Waris
104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
adds support for COMPILE_TEST which is useful for compile testing code
changes to the driver and Counter subsystem.
Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Syed Nayyar Waris <syednwaris@gmail.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/counter/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 3dcdb681c4e4..5edd155f1911 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -14,7 +14,7 @@ if COUNTER
config 104_QUAD_8
tristate "ACCES 104-QUAD-8 driver"
- depends on PC104 && X86
+ depends on (PC104 && X86) || COMPILE_TEST
select ISA_BUS_API
help
Say yes here to build support for the ACCES 104-QUAD-8 quadrature
base-commit: 088879292a0a3672a6acc9215174fbc355ed3daa
--
2.33.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends
2022-01-05 9:41 [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends William Breathitt Gray
@ 2022-01-09 21:22 ` Uwe Kleine-König
2022-01-10 5:36 ` William Breathitt Gray
0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2022-01-09 21:22 UTC (permalink / raw)
To: William Breathitt Gray
Cc: Jonathan.Cameron, linux-iio, linux-kernel, Syed Nayyar Waris
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> adds support for COMPILE_TEST which is useful for compile testing code
> changes to the driver and Counter subsystem.
>
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> drivers/counter/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 3dcdb681c4e4..5edd155f1911 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -14,7 +14,7 @@ if COUNTER
>
> config 104_QUAD_8
> tristate "ACCES 104-QUAD-8 driver"
> - depends on PC104 && X86
> + depends on (PC104 && X86) || COMPILE_TEST
The driver uses inb and friends. Without looking I wonder if there is
something like HAVE_IO or similar this needs to depend on for that?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends
2022-01-09 21:22 ` Uwe Kleine-König
@ 2022-01-10 5:36 ` William Breathitt Gray
2022-01-10 8:36 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: William Breathitt Gray @ 2022-01-10 5:36 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Jonathan.Cameron, linux-iio, linux-kernel, Syed Nayyar Waris
[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]
On Sun, Jan 09, 2022 at 10:22:51PM +0100, Uwe Kleine-König wrote:
> On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> > 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> > adds support for COMPILE_TEST which is useful for compile testing code
> > changes to the driver and Counter subsystem.
> >
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> > ---
> > drivers/counter/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 3dcdb681c4e4..5edd155f1911 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -14,7 +14,7 @@ if COUNTER
> >
> > config 104_QUAD_8
> > tristate "ACCES 104-QUAD-8 driver"
> > - depends on PC104 && X86
> > + depends on (PC104 && X86) || COMPILE_TEST
>
> The driver uses inb and friends. Without looking I wonder if there is
> something like HAVE_IO or similar this needs to depend on for that?
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
If I'm not mistaken, on unsupported architectures include/linux/io.h
will pull in include/asm-generic/io.h which has default implementations
for inb and friends if they are not otherwise defined. It doesn't look
like these default implementations are guarded by a Kconfig setting so
we should be fine in this case.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends
2022-01-10 5:36 ` William Breathitt Gray
@ 2022-01-10 8:36 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2022-01-10 8:36 UTC (permalink / raw)
To: William Breathitt Gray
Cc: Jonathan.Cameron, linux-iio, linux-kernel, Syed Nayyar Waris
[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]
On Mon, Jan 10, 2022 at 02:36:54PM +0900, William Breathitt Gray wrote:
> On Sun, Jan 09, 2022 at 10:22:51PM +0100, Uwe Kleine-König wrote:
> > On Wed, Jan 05, 2022 at 06:41:37PM +0900, William Breathitt Gray wrote:
> > > 104_QUAD_8 depends on X86, but compiles fine on ARCH=arm. This patch
> > > adds support for COMPILE_TEST which is useful for compile testing code
> > > changes to the driver and Counter subsystem.
> > >
> > > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> > > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> > > ---
> > > drivers/counter/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > > index 3dcdb681c4e4..5edd155f1911 100644
> > > --- a/drivers/counter/Kconfig
> > > +++ b/drivers/counter/Kconfig
> > > @@ -14,7 +14,7 @@ if COUNTER
> > >
> > > config 104_QUAD_8
> > > tristate "ACCES 104-QUAD-8 driver"
> > > - depends on PC104 && X86
> > > + depends on (PC104 && X86) || COMPILE_TEST
> >
> > The driver uses inb and friends. Without looking I wonder if there is
> > something like HAVE_IO or similar this needs to depend on for that?
> >
> > Best regards
> > Uwe
> >
> > --
> > Pengutronix e.K. | Uwe Kleine-König |
> > Industrial Linux Solutions | https://www.pengutronix.de/ |
>
> If I'm not mistaken, on unsupported architectures include/linux/io.h
> will pull in include/asm-generic/io.h which has default implementations
> for inb and friends if they are not otherwise defined. It doesn't look
> like these default implementations are guarded by a Kconfig setting so
> we should be fine in this case.
Looks right, thanks for checking
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-10 8:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 9:41 [PATCH] counter: 104-quad-8: Add COMPILE_TEST depends William Breathitt Gray
2022-01-09 21:22 ` Uwe Kleine-König
2022-01-10 5:36 ` William Breathitt Gray
2022-01-10 8:36 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome