* [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS @ 2021-11-10 22:00 Jiri Vanek 2021-11-18 14:50 ` Robert Foss 2022-01-06 19:00 ` [PATCH v2] " Jiri Vanek 0 siblings, 2 replies; 8+ messages in thread From: Jiri Vanek @ 2021-11-10 22:00 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, dri-devel, linux-kernel, Jiri Vanek Fixed wrong register shift for single/dual link LVDS output. Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) } #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS 2021-11-10 22:00 [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS Jiri Vanek @ 2021-11-18 14:50 ` Robert Foss [not found] ` <CAGWqDJ5ZKJ0skLnhfhC0cbzNnSo7HLY7Cqr2ZhOcb_YiHNsA1A@mail.gmail.com> 2022-01-06 19:00 ` [PATCH v2] " Jiri Vanek 1 sibling, 1 reply; 8+ messages in thread From: Robert Foss @ 2021-11-18 14:50 UTC (permalink / raw) To: Jiri Vanek, Zheng Bin, Vinay Simha BN Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, dri-devel, linux-kernel + Zhen & Vinay This patch looks good in itself, but I would like to see a tested by tag. At the very least testing for regression in single-link LVDS but ideally some third party verification of this patch. On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote: > > Fixed wrong register shift for single/dual link LVDS output. > > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> > --- > drivers/gpu/drm/bridge/tc358775.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c > index 2272adcc5b4a..1d6ec1baeff2 100644 > --- a/drivers/gpu/drm/bridge/tc358775.c > +++ b/drivers/gpu/drm/bridge/tc358775.c > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) > } > > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) > { > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & > -- > 2.30.2 > ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAGWqDJ5ZKJ0skLnhfhC0cbzNnSo7HLY7Cqr2ZhOcb_YiHNsA1A@mail.gmail.com>]
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS [not found] ` <CAGWqDJ5ZKJ0skLnhfhC0cbzNnSo7HLY7Cqr2ZhOcb_YiHNsA1A@mail.gmail.com> @ 2022-01-04 13:50 ` Robert Foss [not found] ` <CAECvnWLivbpHQc1Qu0NowXFhSHgQModwcwG0=zviqmGPxnjUHg@mail.gmail.com> 2022-01-04 16:56 ` Vinay Simha B N 0 siblings, 2 replies; 8+ messages in thread From: Robert Foss @ 2022-01-04 13:50 UTC (permalink / raw) To: Vinay Simha B N Cc: Jiri Vanek, Zheng Bin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS, open list Jiri: Are you able to test this patch? Vinay: Could you supply a R-b tag, if you feel that it is warranted? On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote: > > Robert, > I do not have the hardware to test this feature. Sorry for the late response. > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote: >> >> + Zhen & Vinay >> >> This patch looks good in itself, but I would like to see a tested by >> tag. At the very least testing for regression in single-link LVDS but >> ideally some third party verification of this patch. >> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote: >> > >> > Fixed wrong register shift for single/dual link LVDS output. >> > >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> >> > --- >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c >> > index 2272adcc5b4a..1d6ec1baeff2 100644 >> > --- a/drivers/gpu/drm/bridge/tc358775.c >> > +++ b/drivers/gpu/drm/bridge/tc358775.c >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) >> > } >> > >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) >> > { >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & >> > -- >> > 2.30.2 >> > > > > > -- > regards, > vinaysimha ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAECvnWLivbpHQc1Qu0NowXFhSHgQModwcwG0=zviqmGPxnjUHg@mail.gmail.com>]
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS [not found] ` <CAECvnWLivbpHQc1Qu0NowXFhSHgQModwcwG0=zviqmGPxnjUHg@mail.gmail.com> @ 2022-01-04 14:36 ` Robert Foss 2022-01-04 17:04 ` Vinay Simha B N 1 sibling, 0 replies; 8+ messages in thread From: Robert Foss @ 2022-01-04 14:36 UTC (permalink / raw) To: Jiří Vaněk Cc: Vinay Simha B N, Zheng Bin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS, open list Excellent. Jiri, can you add your Tested-by tag to this patch? On Tue, 4 Jan 2022 at 15:29, Jiří Vaněk <jirivanek1@gmail.com> wrote: > > Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all. > > út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org> napsal: >> >> Jiri: Are you able to test this patch? >> >> Vinay: Could you supply a R-b tag, if you feel that it is warranted? >> >> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote: >> > >> > Robert, >> > I do not have the hardware to test this feature. Sorry for the late response. >> > >> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote: >> >> >> >> + Zhen & Vinay >> >> >> >> This patch looks good in itself, but I would like to see a tested by >> >> tag. At the very least testing for regression in single-link LVDS but >> >> ideally some third party verification of this patch. >> >> >> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote: >> >> > >> >> > Fixed wrong register shift for single/dual link LVDS output. >> >> > >> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> >> >> > --- >> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- >> >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c >> >> > index 2272adcc5b4a..1d6ec1baeff2 100644 >> >> > --- a/drivers/gpu/drm/bridge/tc358775.c >> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c >> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) >> >> > } >> >> > >> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 >> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 >> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 >> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) >> >> > { >> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & >> >> > -- >> >> > 2.30.2 >> >> > >> > >> > >> > >> > -- >> > regards, >> > vinaysimha ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS [not found] ` <CAECvnWLivbpHQc1Qu0NowXFhSHgQModwcwG0=zviqmGPxnjUHg@mail.gmail.com> 2022-01-04 14:36 ` Robert Foss @ 2022-01-04 17:04 ` Vinay Simha B N 1 sibling, 0 replies; 8+ messages in thread From: Vinay Simha B N @ 2022-01-04 17:04 UTC (permalink / raw) To: Jiří Vaněk Cc: Robert Foss, Zheng Bin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS, open list Jiri Vanek, Could you please share the part number or datasheet of the dual-link LVDS display used. On Tue, Jan 4, 2022 at 7:59 PM Jiří Vaněk <jirivanek1@gmail.com> wrote: > > Actually, this patch is based on testing with a real HW with dual-link LVDS display (full HD) and it also matches with a datasheet. Without this fix it does not work at all. > > út 4. 1. 2022 v 14:51 odesílatel Robert Foss <robert.foss@linaro.org> napsal: >> >> Jiri: Are you able to test this patch? >> >> Vinay: Could you supply a R-b tag, if you feel that it is warranted? >> >> On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote: >> > >> > Robert, >> > I do not have the hardware to test this feature. Sorry for the late response. >> > >> > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote: >> >> >> >> + Zhen & Vinay >> >> >> >> This patch looks good in itself, but I would like to see a tested by >> >> tag. At the very least testing for regression in single-link LVDS but >> >> ideally some third party verification of this patch. >> >> >> >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote: >> >> > >> >> > Fixed wrong register shift for single/dual link LVDS output. >> >> > >> >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> >> >> > --- >> >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- >> >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >> >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c >> >> > index 2272adcc5b4a..1d6ec1baeff2 100644 >> >> > --- a/drivers/gpu/drm/bridge/tc358775.c >> >> > +++ b/drivers/gpu/drm/bridge/tc358775.c >> >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) >> >> > } >> >> > >> >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 >> >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 >> >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 >> >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) >> >> > { >> >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & >> >> > -- >> >> > 2.30.2 >> >> > >> > >> > >> > >> > -- >> > regards, >> > vinaysimha -- regards, vinaysimha ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS 2022-01-04 13:50 ` Robert Foss [not found] ` <CAECvnWLivbpHQc1Qu0NowXFhSHgQModwcwG0=zviqmGPxnjUHg@mail.gmail.com> @ 2022-01-04 16:56 ` Vinay Simha B N 1 sibling, 0 replies; 8+ messages in thread From: Vinay Simha B N @ 2022-01-04 16:56 UTC (permalink / raw) To: Robert Foss Cc: Jiri Vanek, Zheng Bin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS, open list Robert, What is R-b tag? On Tue, Jan 4, 2022 at 7:21 PM Robert Foss <robert.foss@linaro.org> wrote: > > Jiri: Are you able to test this patch? > > Vinay: Could you supply a R-b tag, if you feel that it is warranted? > > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs@gmail.com> wrote: > > > > Robert, > > I do not have the hardware to test this feature. Sorry for the late response. > > > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss@linaro.org> wrote: > >> > >> + Zhen & Vinay > >> > >> This patch looks good in itself, but I would like to see a tested by > >> tag. At the very least testing for regression in single-link LVDS but > >> ideally some third party verification of this patch. > >> > >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1@gmail.com> wrote: > >> > > >> > Fixed wrong register shift for single/dual link LVDS output. > >> > > >> > Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> > >> > --- > >> > drivers/gpu/drm/bridge/tc358775.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c > >> > index 2272adcc5b4a..1d6ec1baeff2 100644 > >> > --- a/drivers/gpu/drm/bridge/tc358775.c > >> > +++ b/drivers/gpu/drm/bridge/tc358775.c > >> > @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) > >> > } > >> > > >> > #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 > >> > -#define TC358775_LVCFG_LVDLINK__SHIFT 0 > >> > +#define TC358775_LVCFG_LVDLINK__SHIFT 1 > >> > static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) > >> > { > >> > return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & > >> > -- > >> > 2.30.2 > >> > > > > > > > > > -- > > regards, > > vinaysimha -- regards, vinaysimha ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS 2021-11-10 22:00 [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS Jiri Vanek 2021-11-18 14:50 ` Robert Foss @ 2022-01-06 19:00 ` Jiri Vanek [not found] ` <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com> 1 sibling, 1 reply; 8+ messages in thread From: Jiri Vanek @ 2022-01-06 19:00 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, dri-devel, linux-kernel, Vinay Simha B N, Jiri Vanek Fixed wrong register shift for single/dual link LVDS output. Tested-by: Jiri Vanek <jirivanek1@gmail.com> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> --- v1: * Initial version v2: * Tested-by tag added --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 2272adcc5b4a..1d6ec1baeff2 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) } #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 -#define TC358775_LVCFG_LVDLINK__SHIFT 0 +#define TC358775_LVCFG_LVDLINK__SHIFT 1 static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) { return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & -- 2.30.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com>]
* Re: [PATCH v2] drm/bridge/tc358775: Fix for dual-link LVDS [not found] ` <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com> @ 2022-01-07 16:39 ` Robert Foss 0 siblings, 0 replies; 8+ messages in thread From: Robert Foss @ 2022-01-07 16:39 UTC (permalink / raw) To: Vinay Simha B N Cc: Jiri Vanek, Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, open list:DRM PANEL DRIVERS, open list On Thu, 6 Jan 2022 at 20:22, Vinay Simha B N <simhavcs@gmail.com> wrote: > > Reviewed-by: Vinay Simha BN <simhavcs@gmail.com> > > Jiri Vanek, > Could you please share the part number or datasheet of the dual-link LVDS display/panel used. > > > On Fri, Jan 7, 2022 at 12:30 AM Jiri Vanek <jirivanek1@gmail.com> wrote: >> >> Fixed wrong register shift for single/dual link LVDS output. >> >> Tested-by: Jiri Vanek <jirivanek1@gmail.com> >> Signed-off-by: Jiri Vanek <jirivanek1@gmail.com> >> >> --- >> v1: >> * Initial version >> >> v2: >> * Tested-by tag added >> >> --- >> drivers/gpu/drm/bridge/tc358775.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c >> index 2272adcc5b4a..1d6ec1baeff2 100644 >> --- a/drivers/gpu/drm/bridge/tc358775.c >> +++ b/drivers/gpu/drm/bridge/tc358775.c >> @@ -241,7 +241,7 @@ static inline u32 TC358775_LVCFG_PCLKDIV(uint32_t val) >> } >> >> #define TC358775_LVCFG_LVDLINK__MASK 0x00000002 >> -#define TC358775_LVCFG_LVDLINK__SHIFT 0 >> +#define TC358775_LVCFG_LVDLINK__SHIFT 1 >> static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val) >> { >> return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) & >> -- Applied to drm-misc-next ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-01-07 16:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 22:00 [PATCH] drm/bridge/tc358775: Fix for dual-link LVDS Jiri Vanek
2021-11-18 14:50 ` Robert Foss
[not found] ` <CAGWqDJ5ZKJ0skLnhfhC0cbzNnSo7HLY7Cqr2ZhOcb_YiHNsA1A@mail.gmail.com>
2022-01-04 13:50 ` Robert Foss
[not found] ` <CAECvnWLivbpHQc1Qu0NowXFhSHgQModwcwG0=zviqmGPxnjUHg@mail.gmail.com>
2022-01-04 14:36 ` Robert Foss
2022-01-04 17:04 ` Vinay Simha B N
2022-01-04 16:56 ` Vinay Simha B N
2022-01-06 19:00 ` [PATCH v2] " Jiri Vanek
[not found] ` <CAGWqDJ6T6EGNjoc2qfNHLMdcuwcnJArF7a7sToRXJ90Zs57E_A@mail.gmail.com>
2022-01-07 16:39 ` Robert Foss
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome