From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Brian Silverman <brian.silverman@bluerivertech.com>
Cc: Brian Silverman <bsilver16384@gmail.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
"open list:CAN NETWORK DRIVERS" <linux-can@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] can: gs_usb: Zero-initialize flags
Date: Sat, 8 Jan 2022 23:29:04 +0100 [thread overview]
Message-ID: <20220108222904.plwxywgmnwrwpvmt@pengutronix.de> (raw)
In-Reply-To: <20220106002952.25883-1-brian.silverman@bluerivertech.com>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On 05.01.2022 16:29:50, Brian Silverman wrote:
> No information is deliberately sent here in host->device communications,
> but the open-source candleLight firmware echoes it back, which can
> result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
> spurious ERRORFRAMEs.
>
> Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
Applied to linux-can/testing + opened an issue on github:
https://github.com/candle-usb/candleLight_fw/issues/87
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-01-08 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 0:29 Brian Silverman
2022-01-08 22:29 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220108222904.plwxywgmnwrwpvmt@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=brian.silverman@bluerivertech.com \
--cc=bsilver16384@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®