From: Brian Silverman <brian.silverman@bluerivertech.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Brian Silverman <bsilver16384@gmail.com>,
Brian Silverman <brian.silverman@bluerivertech.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
linux-can@vger.kernel.org (open list:CAN NETWORK DRIVERS),
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] can: gs_usb: Zero-initialize flags
Date: Wed, 5 Jan 2022 16:29:50 -0800 [thread overview]
Message-ID: <20220106002952.25883-1-brian.silverman@bluerivertech.com> (raw)
No information is deliberately sent here in host->device communications,
but the open-source candleLight firmware echoes it back, which can
result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
spurious ERRORFRAMEs.
Signed-off-by: Brian Silverman <brian.silverman@bluerivertech.com>
---
drivers/net/can/usb/gs_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 1b400de00f51..cc4ad8d59bd7 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,
hf->echo_id = idx;
hf->channel = dev->channel;
+ hf->flags = 0;
cf = (struct can_frame *)skb->data;
base-commit: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
--
2.20.1
next reply other threads:[~2022-01-06 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 0:29 Brian Silverman [this message]
2022-01-08 22:29 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106002952.25883-1-brian.silverman@bluerivertech.com \
--to=brian.silverman@bluerivertech.com \
--cc=bsilver16384@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®