* [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
@ 2022-01-11 3:40 lzmlzm
2022-01-13 10:14 ` Robert Foss
0 siblings, 1 reply; 2+ messages in thread
From: lzmlzm @ 2022-01-11 3:40 UTC (permalink / raw)
To: a.hajda, narmstrong, robert.foss
Cc: Laurent.pinchart, jonas, jernej.skrabec, airlied, daniel,
dri-devel, linux-kernel, lzmlzm
Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +-
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..e0feb4fd9780 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
if (!lt9611)
return -ENOMEM;
- lt9611->dev = &client->dev;
+ lt9611->dev = dev;
lt9611->client = client;
lt9611->sleep = false;
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..e50e42312e82 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
if (!lt9611uxc)
return -ENOMEM;
- lt9611uxc->dev = &client->dev;
+ lt9611uxc->dev = dev;
lt9611uxc->client = client;
mutex_init(<9611uxc->ocm_lock);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver
2022-01-11 3:40 [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver lzmlzm
@ 2022-01-13 10:14 ` Robert Foss
0 siblings, 0 replies; 2+ messages in thread
From: Robert Foss @ 2022-01-13 10:14 UTC (permalink / raw)
To: lzmlzm
Cc: a.hajda, narmstrong, laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel, dri-devel, linux-kernel
Hello,
Thanks for submitting this cleanup patch.
On Tue, 11 Jan 2022 at 04:41, lzmlzm <lzmlzmhh@gmail.com> wrote:
>
A commit message is necessary for all changes, no matter how trivial.
> Signed-off-by: lzmlzm <lzmlzmhh@gmail.com>
Is your name listed correctly above? For the 'Signed-off-by' tag to be
meaningful, a real name needs to be supplied.
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +-
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index dafb1b47c15f..e0feb4fd9780 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
> if (!lt9611)
> return -ENOMEM;
>
> - lt9611->dev = &client->dev;
> + lt9611->dev = dev;
> lt9611->client = client;
> lt9611->sleep = false;
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 33f9716da0ee..e50e42312e82 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> if (!lt9611uxc)
> return -ENOMEM;
>
> - lt9611uxc->dev = &client->dev;
> + lt9611uxc->dev = dev;
> lt9611uxc->client = client;
> mutex_init(<9611uxc->ocm_lock);
>
> --
With these two issues fixed, please submit a v2 of this patch.
Rob.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-13 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 3:40 [PATCH] Remove extra device acquisition method of i2c client in lt9611 driver lzmlzm
2022-01-13 10:14 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®