* [PATCH] drm/vc4: remove redundant assignment of variable size
@ 2022-01-12 23:20 Colin Ian King
2022-01-14 13:15 ` (subset) " Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-01-12 23:20 UTC (permalink / raw)
To: Emma Anholt, Maxime Ripard, David Airlie, Daniel Vetter, dri-devel
Cc: kernel-janitors, linux-kernel, llvm
The variable 'size' is being assigned a value that is never read,
the assignment is redundant and can be removed. Cleans up clang-scan
warning:
drivers/gpu/drm/vc4/vc4_bo.c:358:2: warning: Value stored to 'size'
is never read [deadcode.DeadStores]
size = roundup(size, PAGE_SIZE);
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/vc4/vc4_bo.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 6d1281a343e9..e451cc5bcfac 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -355,8 +355,6 @@ static struct vc4_bo *vc4_bo_get_from_cache(struct drm_device *dev,
uint32_t page_index = bo_page_index(size);
struct vc4_bo *bo = NULL;
- size = roundup(size, PAGE_SIZE);
-
mutex_lock(&vc4->bo_lock);
if (page_index >= vc4->bo_cache.size_list_size)
goto out;
--
2.33.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] drm/vc4: remove redundant assignment of variable size
2022-01-12 23:20 [PATCH] drm/vc4: remove redundant assignment of variable size Colin Ian King
@ 2022-01-14 13:15 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2022-01-14 13:15 UTC (permalink / raw)
To: Emma Anholt, Maxime Ripard, David Airlie, Colin Ian King,
Daniel Vetter, dri-devel
Cc: Maxime Ripard, kernel-janitors, linux-kernel, llvm
On Wed, 12 Jan 2022 23:20:36 +0000, Colin Ian King wrote:
> The variable 'size' is being assigned a value that is never read,
> the assignment is redundant and can be removed. Cleans up clang-scan
> warning:
>
> drivers/gpu/drm/vc4/vc4_bo.c:358:2: warning: Value stored to 'size'
> is never read [deadcode.DeadStores]
> size = roundup(size, PAGE_SIZE);
>
> [...]
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-14 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 23:20 [PATCH] drm/vc4: remove redundant assignment of variable size Colin Ian King
2022-01-14 13:15 ` (subset) " Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®