* [PATCH] crypto: asymmetric_keys: remove redundant pointer secs
@ 2022-01-12 23:34 Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2022-01-12 23:34 UTC (permalink / raw)
To: David Howells, Herbert Xu, David S . Miller, Nathan Chancellor,
keyrings, linux-crypto
Cc: kernel-janitors, linux-kernel, llvm
The pointer secs is assigned a value but it is never read. The
pointer is redundant and can be removed. Cleans up clang scan
warning:
crypto/asymmetric_keys/verify_pefile.c:113:14: warning: Although
the value stored to 'secs' is used in the enclosing expression,
the value is never actually read from 'secs' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
crypto/asymmetric_keys/verify_pefile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
index 7553ab18db89..a660e4d68d50 100644
--- a/crypto/asymmetric_keys/verify_pefile.c
+++ b/crypto/asymmetric_keys/verify_pefile.c
@@ -28,7 +28,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen,
const struct pe32plus_opt_hdr *pe64;
const struct data_directory *ddir;
const struct data_dirent *dde;
- const struct section_header *secs, *sec;
+ const struct section_header *sec;
size_t cursor, datalen = pelen;
kenter("");
@@ -110,7 +110,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen,
ctx->n_sections = pe->sections;
if (ctx->n_sections > (ctx->header_size - cursor) / sizeof(*sec))
return -ELIBBAD;
- ctx->secs = secs = pebuf + cursor;
+ ctx->secs = pebuf + cursor;
return 0;
}
--
2.33.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] crypto: asymmetric_keys: remove redundant pointer secs
@ 2022-05-16 21:17 Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2022-05-16 21:17 UTC (permalink / raw)
To: David Howells, Herbert Xu, David S . Miller, keyrings, linux-crypto
Cc: kernel-janitors, linux-kernel
Pointer secs is being assigned a value that is never read. The pointer
is redundant and can be removed.
Cleans up clang-scan build warning:
warning: Although the value stored to 'secs' is used in the enclosing
expression, the value is never actually read from 'secs'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
crypto/asymmetric_keys/verify_pefile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
index 7553ab18db89..a660e4d68d50 100644
--- a/crypto/asymmetric_keys/verify_pefile.c
+++ b/crypto/asymmetric_keys/verify_pefile.c
@@ -28,7 +28,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen,
const struct pe32plus_opt_hdr *pe64;
const struct data_directory *ddir;
const struct data_dirent *dde;
- const struct section_header *secs, *sec;
+ const struct section_header *sec;
size_t cursor, datalen = pelen;
kenter("");
@@ -110,7 +110,7 @@ static int pefile_parse_binary(const void *pebuf, unsigned int pelen,
ctx->n_sections = pe->sections;
if (ctx->n_sections > (ctx->header_size - cursor) / sizeof(*sec))
return -ELIBBAD;
- ctx->secs = secs = pebuf + cursor;
+ ctx->secs = pebuf + cursor;
return 0;
}
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 23:34 [PATCH] crypto: asymmetric_keys: remove redundant pointer secs Colin Ian King
2022-05-16 21:17 Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®