* [PATCH] ACPI: PCC: make pcc_ctx static
@ 2022-01-13 16:18 Jiapeng Chong
2022-01-14 10:30 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-01-13 16:18 UTC (permalink / raw)
To: rafael; +Cc: lenb, linux-acpi, linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of acpi_pcc.c, so marks it static.
Fix the following sparse warning:
drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not
declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/acpi/acpi_pcc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c
index 41e3ebd204ff..a12b55d81209 100644
--- a/drivers/acpi/acpi_pcc.c
+++ b/drivers/acpi/acpi_pcc.c
@@ -31,7 +31,7 @@ struct pcc_data {
struct acpi_pcc_info ctx;
};
-struct acpi_pcc_info pcc_ctx;
+static struct acpi_pcc_info pcc_ctx;
static void pcc_rx_callback(struct mbox_client *cl, void *m)
{
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: PCC: make pcc_ctx static
2022-01-13 16:18 [PATCH] ACPI: PCC: make pcc_ctx static Jiapeng Chong
@ 2022-01-14 10:30 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2022-01-14 10:30 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: rafael, lenb, linux-acpi, linux-kernel, Abaci Robot
On Fri, Jan 14, 2022 at 12:18:46AM +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acpi_pcc.c, so marks it static.
>
> Fix the following sparse warning:
>
> drivers/acpi/acpi_pcc.c:34:22: warning: symbol 'pcc_ctx' was not
> declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
The fix is now already applied [1]
--
Regards,
Sudeep
[1] https://lore.kernel.org/lkml/CAJZ5v0iG0-O1m2hS62yXMNW4p1JhWhxXZCDQc=mxKc50mU7GZw@mail.gmail.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-14 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-13 16:18 [PATCH] ACPI: PCC: make pcc_ctx static Jiapeng Chong
2022-01-14 10:30 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®