* [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe
@ 2022-01-14 6:51 Miaoqian Lin
2022-01-16 12:07 ` Linus Walleij
2022-01-17 13:19 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-01-14 6:51 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Thomas Bogendoerfer,
linux-gpio, linux-kernel
Cc: linmq006
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpio/gpio-idt3243x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
index 50003ad2e589..08493b05be2d 100644
--- a/drivers/gpio/gpio-idt3243x.c
+++ b/drivers/gpio/gpio-idt3243x.c
@@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
return PTR_ERR(ctrl->pic);
parent_irq = platform_get_irq(pdev, 0);
- if (!parent_irq)
- return -EINVAL;
+ if (parent_irq < 0)
+ return parent_irq;
girq = &ctrl->gc.irq;
girq->chip = &idt_gpio_irqchip;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe
2022-01-14 6:51 [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe Miaoqian Lin
@ 2022-01-16 12:07 ` Linus Walleij
2022-01-17 13:19 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-01-16 12:07 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Bartosz Golaszewski, Thomas Bogendoerfer, linux-gpio, linux-kernel
On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe
2022-01-14 6:51 [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe Miaoqian Lin
2022-01-16 12:07 ` Linus Walleij
@ 2022-01-17 13:19 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2022-01-17 13:19 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Linus Walleij, Thomas Bogendoerfer, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/gpio/gpio-idt3243x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
> index 50003ad2e589..08493b05be2d 100644
> --- a/drivers/gpio/gpio-idt3243x.c
> +++ b/drivers/gpio/gpio-idt3243x.c
> @@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
> return PTR_ERR(ctrl->pic);
>
> parent_irq = platform_get_irq(pdev, 0);
> - if (!parent_irq)
> - return -EINVAL;
> + if (parent_irq < 0)
> + return parent_irq;
>
> girq = &ctrl->gc.irq;
> girq->chip = &idt_gpio_irqchip;
> --
> 2.17.1
>
Queued for fixes, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-17 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 6:51 [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe Miaoqian Lin
2022-01-16 12:07 ` Linus Walleij
2022-01-17 13:19 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®