* [PATCH] media: mtk-mdp: Remove redundant 'flush_workqueue()' calls
@ 2022-01-14 8:22 Xu Wang
2022-01-14 10:26 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2022-01-14 8:22 UTC (permalink / raw)
To: minghsiu.tsai, houlong.wei, andrew-ct.chen, mchehab, matthias.bgg
Cc: linux-media, linux-arm-kernel, linux-mediatek, linux-kernel
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.
Remove the redundant 'flush_workqueue()' calls.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
index 3d38793aaa25..fbd6e06a0567 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_core.c
@@ -246,10 +246,8 @@ static int mtk_mdp_remove(struct platform_device *pdev)
mtk_mdp_unregister_m2m_device(mdp);
v4l2_device_unregister(&mdp->v4l2_dev);
- flush_workqueue(mdp->wdt_wq);
destroy_workqueue(mdp->wdt_wq);
- flush_workqueue(mdp->job_wq);
destroy_workqueue(mdp->job_wq);
list_for_each_entry_safe(comp, comp_temp, &mdp->comp_list, node) {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: mtk-mdp: Remove redundant 'flush_workqueue()' calls
2022-01-14 8:22 [PATCH] media: mtk-mdp: Remove redundant 'flush_workqueue()' calls Xu Wang
@ 2022-01-14 10:26 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-01-14 10:26 UTC (permalink / raw)
To: Xu Wang, minghsiu.tsai, houlong.wei, andrew-ct.chen, mchehab,
matthias.bgg
Cc: linux-media, linux-arm-kernel, linux-mediatek, linux-kernel
Il 14/01/22 09:22, Xu Wang ha scritto:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-14 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 8:22 [PATCH] media: mtk-mdp: Remove redundant 'flush_workqueue()' calls Xu Wang
2022-01-14 10:26 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®