mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] input: fix Kconfig dependency on IIO_BUFFER
@ 2022-01-17  6:07 Julian Braha
  0 siblings, 0 replies; only message in thread
From: Julian Braha @ 2022-01-17  6:07 UTC (permalink / raw)
  To: dmitry.torokhov, johannes.berg, richard, oleg, cand
  Cc: linux-input, linux-kernel, fazilyildiran

When JOYSTICK_ADC is enabled, and IIO_BUFFER is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
  Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
  Selected by [y]:
  - JOYSTICK_ADC [=y] && !UML && INPUT [=y] && INPUT_JOYSTICK [=y] && IIO [=y]

This is because JOYSTICK_ADC selects IIO_BUFFER_CB
without selecting or depending on IIO_BUFFER,
despite IIO_BUFFER_CB depending on IIO_BUFFER.

This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/input/joystick/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
index 3b23078bc7b5..db4135bbd279 100644
--- a/drivers/input/joystick/Kconfig
+++ b/drivers/input/joystick/Kconfig
@@ -46,6 +46,7 @@ config JOYSTICK_A3D
 config JOYSTICK_ADC
 	tristate "Simple joystick connected over ADC"
 	depends on IIO
+	select IIO_BUFFER
 	select IIO_BUFFER_CB
 	help
 	  Say Y here if you have a simple joystick connected over ADC.
-- 
2.32.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-17  6:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17  6:07 [PATCH] input: fix Kconfig dependency on IIO_BUFFER Julian Braha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®