mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: acp-mach: Fix Left and Right rt1019 amp devices
@ 2022-01-20 13:36 Ajit Kumar Pandey
  2022-01-25 10:20 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Ajit Kumar Pandey @ 2022-01-20 13:36 UTC (permalink / raw)
  To: broonie, alsa-devel
  Cc: Vijendar.Mukunda, Alexander.Deucher, Basavaraj.Hiregoudar,
	Sunil-kumar.Dommati, Ajit Kumar Pandey, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, V sujith kumar Reddy, open list

We're setting wrong card codec conf for rt1019 amp devices in our
machine driver. Due to this left and right amp channels data are
reversed in our machines as wrong device prefix results in wrong
value for "Mono LR Select" rt1019 mixer control. Reverse dev ids
in codec conf with Left and Right name_prefix to fix such issue.

Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
---
 sound/soc/amd/acp/acp-mach-common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
index c9caade5cb74..cd05ee2802c9 100644
--- a/sound/soc/amd/acp/acp-mach-common.c
+++ b/sound/soc/amd/acp/acp-mach-common.c
@@ -303,11 +303,11 @@ static const struct snd_soc_dapm_route rt1019_map_lr[] = {
 
 static struct snd_soc_codec_conf rt1019_conf[] = {
 	{
-		 .dlc = COMP_CODEC_CONF("i2c-10EC1019:00"),
+		 .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
 		 .name_prefix = "Left",
 	},
 	{
-		 .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
+		 .dlc = COMP_CODEC_CONF("i2c-10EC1019:00"),
 		 .name_prefix = "Right",
 	},
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: amd: acp-mach: Fix Left and Right rt1019 amp devices
  2022-01-20 13:36 [PATCH] ASoC: amd: acp-mach: Fix Left and Right rt1019 amp devices Ajit Kumar Pandey
@ 2022-01-25 10:20 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-01-25 10:20 UTC (permalink / raw)
  To: alsa-devel, Ajit Kumar Pandey
  Cc: Alexander.Deucher, V sujith kumar Reddy, Liam Girdwood,
	open list, Takashi Iwai, Sunil-kumar.Dommati, Vijendar.Mukunda,
	Jaroslav Kysela, Basavaraj.Hiregoudar

On Thu, 20 Jan 2022 19:06:01 +0530, Ajit Kumar Pandey wrote:
> We're setting wrong card codec conf for rt1019 amp devices in our
> machine driver. Due to this left and right amp channels data are
> reversed in our machines as wrong device prefix results in wrong
> value for "Mono LR Select" rt1019 mixer control. Reverse dev ids
> in codec conf with Left and Right name_prefix to fix such issue.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus

Thanks!

[1/1] ASoC: amd: acp-mach: Fix Left and Right rt1019 amp devices
      commit: 248be352bbae1a0f14d0d3511a5b0bb9665097f5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-25 10:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 13:36 [PATCH] ASoC: amd: acp-mach: Fix Left and Right rt1019 amp devices Ajit Kumar Pandey
2022-01-25 10:20 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome