From: Luiz Sampaio <sampaio.ime@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-kernel@vger.kernel.org,
Luiz Sampaio <sampaio.ime@gmail.com>,
linux-mmc@vger.kernel.org
Subject: [PATCH 13/31] mmc: changing LED_* from enum led_brightness to actual value
Date: Fri, 21 Jan 2022 13:54:18 -0300 [thread overview]
Message-ID: <20220121165436.30956-14-sampaio.ime@gmail.com> (raw)
In-Reply-To: <20220121165436.30956-1-sampaio.ime@gmail.com>
The enum led_brightness, which contains the declaration of LED_OFF,
LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
max_brightness.
---
drivers/mmc/core/core.c | 4 ++--
drivers/mmc/host/rtsx_usb_sdmmc.c | 4 ++--
drivers/mmc/host/sdhci.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 368f10405e13..66bc9c780e06 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -175,7 +175,7 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq)
mmc_should_fail_request(host, mrq);
if (!host->ongoing_mrq)
- led_trigger_event(host->led, LED_OFF);
+ led_trigger_event(host->led, 0);
if (mrq->sbc) {
pr_debug("%s: req done <CMD%u>: %d: %08x %08x %08x %08x\n",
@@ -352,7 +352,7 @@ int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
if (err)
return err;
- led_trigger_event(host->led, LED_FULL);
+ led_trigger_event(host->led, 255);
__mmc_start_request(host, mrq);
return 0;
diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index 5fe4528e296e..64fe7a75f401 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -1287,7 +1287,7 @@ static void rtsx_usb_update_led(struct work_struct *work)
if (host->power_mode == MMC_POWER_OFF)
goto out;
- if (host->led.brightness == LED_OFF)
+ if (host->led.brightness == 0)
rtsx_usb_turn_off_led(ucr);
else
rtsx_usb_turn_on_led(ucr);
@@ -1357,7 +1357,7 @@ static int rtsx_usb_sdmmc_drv_probe(struct platform_device *pdev)
snprintf(host->led_name, sizeof(host->led_name),
"%s::", mmc_hostname(mmc));
host->led.name = host->led_name;
- host->led.brightness = LED_OFF;
+ host->led.brightness = 0;
host->led.default_trigger = mmc_hostname(mmc);
host->led.brightness_set = rtsx_usb_led_control;
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 07c6da1f2f0f..ddc58a8f0c4f 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -395,7 +395,7 @@ static void sdhci_led_control(struct led_classdev *led,
if (host->runtime_suspended)
goto out;
- if (brightness == LED_OFF)
+ if (brightness == 0)
__sdhci_led_deactivate(host);
else
__sdhci_led_activate(host);
@@ -414,7 +414,7 @@ static int sdhci_led_register(struct sdhci_host *host)
"%s::", mmc_hostname(mmc));
host->led.name = host->led_name;
- host->led.brightness = LED_OFF;
+ host->led.brightness = 0;
host->led.default_trigger = mmc_hostname(mmc);
host->led.brightness_set = sdhci_led_control;
--
2.34.1
next prev parent reply other threads:[~2022-01-21 16:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 16:54 [PATCH 00/31] leds: start removing obsolete/useless enum Luiz Sampaio
2022-01-21 16:54 ` [PATCH 01/31] gpu: nouveau: nouveau_led: changing LED_FULL to actual value Luiz Sampaio
2022-01-22 13:33 ` Fabio Estevam
2022-01-21 16:54 ` [PATCH 02/31] hid: changing LED_* from enum led_brightness " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 03/31] hwmon: pmbus: " Luiz Sampaio
2022-01-25 2:03 ` Guenter Roeck
2022-01-21 16:54 ` [PATCH 04/31] iio: light: cm3605: " Luiz Sampaio
2022-01-22 16:38 ` Jonathan Cameron
2022-01-21 16:54 ` [PATCH 05/31] input: keyboard: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 06/31] input: misc: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 07/31] input: touchscreen: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 08/31] leds: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 09/31] macintosh: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 10/31] media: radio: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 11/31] media: rc: " Luiz Sampaio
2022-01-21 18:06 ` Sean Young
2022-01-21 16:54 ` [PATCH 12/31] media: v4l2-core: " Luiz Sampaio
2022-02-02 12:54 ` Sakari Ailus
2022-11-26 10:14 ` Hans Verkuil
2022-01-21 16:54 ` Luiz Sampaio [this message]
2022-01-21 16:54 ` [PATCH 14/31] net: wireless: ath: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 15/31] net: wireless: atmel: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 16/31] net: broadcom: " Luiz Sampaio
2022-01-22 8:21 ` Arend van Spriel
2022-01-21 16:54 ` [PATCH 17/31] net: intersil: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 18/31] net: wireless: ralink: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 19/31] net: realtek: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 20/31] platform: x86: " Luiz Sampaio
2022-01-22 12:07 ` Jonathan Woithe
2022-01-24 10:14 ` Hans de Goede
2022-01-21 16:54 ` [PATCH 21/31] power: supply: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 22/31] tty: vt: " Luiz Sampaio
2022-01-22 7:32 ` Greg Kroah-Hartman
2022-01-21 16:54 ` [PATCH 23/31] usb: core: " Luiz Sampaio
2022-01-22 7:22 ` Greg Kroah-Hartman
2022-01-21 16:54 ` [PATCH 24/31] video: backlight: " Luiz Sampaio
2022-01-21 17:05 ` Daniel Thompson
2022-01-21 18:06 ` Luiz Sampaio
2022-01-21 18:09 ` Luiz Sampaio
2022-01-24 10:53 ` Lee Jones
2022-01-21 16:54 ` [PATCH 25/31] include: linux: leds: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 26/31] net: bluetooth: " Luiz Sampaio
2022-01-21 20:19 ` Marcel Holtmann
2022-01-21 16:54 ` [PATCH 27/31] net: mac80211 : " Luiz Sampaio
2022-01-21 19:28 ` Johannes Berg
2022-01-21 16:54 ` [PATCH 28/31] net: netfilter: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 29/31] net: rfkill: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 30/31] sound: core: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 31/31] sound: soc: sof: " Luiz Sampaio
2022-02-11 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121165436.30956-14-sampaio.ime@gmail.com \
--to=sampaio.ime@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®