From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Luiz Sampaio <sampaio.ime@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 16/31] net: broadcom: changing LED_* from enum led_brightness to actual value
Date: Sat, 22 Jan 2022 09:21:58 +0100 [thread overview]
Message-ID: <dd9e469a-b1ab-30d1-8f9f-946d4b323c35@broadcom.com> (raw)
In-Reply-To: <20220121165436.30956-17-sampaio.ime@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On 1/21/2022 5:54 PM, Luiz Sampaio wrote:
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.
The commit message sounds a bit obscure to me. You say the
led_brightness enumeration is or rather will become obsolete. I don't
understand the reason given "led class now supports max_brightness".
What does that mean?
Also I do not understand the approach here. If the enum is obsolete why
not start with the APIs using it like the led callbacks
brightness_{get,set{,_blocking}}. I suspect that is your next step, but
it seems like unnecessary churn to me.
Anyway, what triggered me to look at this is the fact that we do have a
led.c under drivers/net/wireless/broadcom/brcm80211/brcmsmac
implementing the brightness_set() callback.
Regards,
Arend
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2022-01-22 8:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 16:54 [PATCH 00/31] leds: start removing obsolete/useless enum Luiz Sampaio
2022-01-21 16:54 ` [PATCH 01/31] gpu: nouveau: nouveau_led: changing LED_FULL to actual value Luiz Sampaio
2022-01-22 13:33 ` Fabio Estevam
2022-01-21 16:54 ` [PATCH 02/31] hid: changing LED_* from enum led_brightness " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 03/31] hwmon: pmbus: " Luiz Sampaio
2022-01-25 2:03 ` Guenter Roeck
2022-01-21 16:54 ` [PATCH 04/31] iio: light: cm3605: " Luiz Sampaio
2022-01-22 16:38 ` Jonathan Cameron
2022-01-21 16:54 ` [PATCH 05/31] input: keyboard: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 06/31] input: misc: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 07/31] input: touchscreen: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 08/31] leds: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 09/31] macintosh: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 10/31] media: radio: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 11/31] media: rc: " Luiz Sampaio
2022-01-21 18:06 ` Sean Young
2022-01-21 16:54 ` [PATCH 12/31] media: v4l2-core: " Luiz Sampaio
2022-02-02 12:54 ` Sakari Ailus
2022-11-26 10:14 ` Hans Verkuil
2022-01-21 16:54 ` [PATCH 13/31] mmc: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 14/31] net: wireless: ath: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 15/31] net: wireless: atmel: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 16/31] net: broadcom: " Luiz Sampaio
2022-01-22 8:21 ` Arend van Spriel [this message]
2022-01-21 16:54 ` [PATCH 17/31] net: intersil: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 18/31] net: wireless: ralink: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 19/31] net: realtek: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 20/31] platform: x86: " Luiz Sampaio
2022-01-22 12:07 ` Jonathan Woithe
2022-01-24 10:14 ` Hans de Goede
2022-01-21 16:54 ` [PATCH 21/31] power: supply: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 22/31] tty: vt: " Luiz Sampaio
2022-01-22 7:32 ` Greg Kroah-Hartman
2022-01-21 16:54 ` [PATCH 23/31] usb: core: " Luiz Sampaio
2022-01-22 7:22 ` Greg Kroah-Hartman
2022-01-21 16:54 ` [PATCH 24/31] video: backlight: " Luiz Sampaio
2022-01-21 17:05 ` Daniel Thompson
2022-01-21 18:06 ` Luiz Sampaio
2022-01-21 18:09 ` Luiz Sampaio
2022-01-24 10:53 ` Lee Jones
2022-01-21 16:54 ` [PATCH 25/31] include: linux: leds: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 26/31] net: bluetooth: " Luiz Sampaio
2022-01-21 20:19 ` Marcel Holtmann
2022-01-21 16:54 ` [PATCH 27/31] net: mac80211 : " Luiz Sampaio
2022-01-21 19:28 ` Johannes Berg
2022-01-21 16:54 ` [PATCH 28/31] net: netfilter: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 29/31] net: rfkill: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 30/31] sound: core: " Luiz Sampaio
2022-01-21 16:54 ` [PATCH 31/31] sound: soc: sof: " Luiz Sampaio
2022-02-11 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd9e469a-b1ab-30d1-8f9f-946d4b323c35@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sampaio.ime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®