[PATCH 0/2] PCI: mt7621: address some kernel test robot reported warnings

[PATCH 0/2] PCI: mt7621: address some kernel test robot reported warnings

[Sergio Paracuellos]

Kernel test robot complains about two things here[0]:
- pcie_rmw() [-Wunused-function]
- 'mt7621_pcie_ids' [-Wunused-const-variable]

Address this two warnings in this small two patches.

Best regards,
    Sergio Paracuellos

[0]: https://lkml.org/lkml/2022/1/24/264

Sergio Paracuellos (2):
  PCI: mt7621: drop 'of_match_ptr' to fix -Wunused-const-variable
  PCI: mt7621: remove unused function pcie_rmw()

 drivers/pci/controller/pcie-mt7621.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

-- 
2.25.1

[PATCH 1/2] PCI: mt7621: drop 'of_match_ptr' to fix -Wunused-const-variable

[Sergio Paracuellos]

The of_device_id is included unconditionally by of.h header and used in the
driver as well. Remove of_match_ptr to fix W=1 compile test warning with
!CONFIG_OF:

drivers/pci/controller/pcie-mt7621.c:549:34: warning: unused variable 'mt7621_pcie_ids' [-Wunused-const-variable]

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver")
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/pci/controller/pcie-mt7621.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 3824862ea144..f2e567282d3e 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -557,7 +557,7 @@ static struct platform_driver mt7621_pcie_driver = {
 	.remove = mt7621_pcie_remove,
 	.driver = {
 		.name = "mt7621-pci",
-		.of_match_table = of_match_ptr(mt7621_pcie_ids),
+		.of_match_table = mt7621_pcie_ids,
 	},
 };
 builtin_platform_driver(mt7621_pcie_driver);
-- 
2.25.1

[PATCH 2/2] PCI: mt7621: remove unused function pcie_rmw()

[Sergio Paracuellos]

Function pcie_rmw() is not being used at all and be deleted. Hence get rid
of it. This fix the following complain warning:

drivers/pci/controller/pcie-mt7621.c:112:20: warning: unused function 'pcie_rmw' [-Wunused-function]

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver")
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/pci/controller/pcie-mt7621.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index f2e567282d3e..33eb37a2225c 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -109,15 +109,6 @@ static inline void pcie_write(struct mt7621_pcie *pcie, u32 val, u32 reg)
 	writel_relaxed(val, pcie->base + reg);
 }
 
-static inline void pcie_rmw(struct mt7621_pcie *pcie, u32 reg, u32 clr, u32 set)
-{
-	u32 val = readl_relaxed(pcie->base + reg);
-
-	val &= ~clr;
-	val |= set;
-	writel_relaxed(val, pcie->base + reg);
-}
-
 static inline u32 pcie_port_read(struct mt7621_pcie_port *port, u32 reg)
 {
 	return readl_relaxed(port->base + reg);
-- 
2.25.1

Re: [PATCH 0/2] PCI: mt7621: address some kernel test robot reported warnings

[Bjorn Helgaas]

On Mon, Jan 24, 2022 at 12:30:01PM +0100, Sergio Paracuellos wrote:
> Kernel test robot complains about two things here[0]:
> - pcie_rmw() [-Wunused-function]
> - 'mt7621_pcie_ids' [-Wunused-const-variable]
> 
> Address this two warnings in this small two patches.
> 
> Best regards,
>     Sergio Paracuellos
> 
> [0]: https://lkml.org/lkml/2022/1/24/264
> 
> Sergio Paracuellos (2):
>   PCI: mt7621: drop 'of_match_ptr' to fix -Wunused-const-variable
>   PCI: mt7621: remove unused function pcie_rmw()
> 
>  drivers/pci/controller/pcie-mt7621.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)

Both applied to for-linus for v5.17, thank you!

Re: [PATCH 0/2] PCI: mt7621: address some kernel test robot reported warnings

[Sergio Paracuellos]

On Wed, Jan 26, 2022 at 1:04 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Mon, Jan 24, 2022 at 12:30:01PM +0100, Sergio Paracuellos wrote:
> > Kernel test robot complains about two things here[0]:
> > - pcie_rmw() [-Wunused-function]
> > - 'mt7621_pcie_ids' [-Wunused-const-variable]
> >
> > Address this two warnings in this small two patches.
> >
> > Best regards,
> >     Sergio Paracuellos
> >
> > [0]: https://lkml.org/lkml/2022/1/24/264
> >
> > Sergio Paracuellos (2):
> >   PCI: mt7621: drop 'of_match_ptr' to fix -Wunused-const-variable
> >   PCI: mt7621: remove unused function pcie_rmw()
> >
> >  drivers/pci/controller/pcie-mt7621.c | 11 +----------
> >  1 file changed, 1 insertion(+), 10 deletions(-)
>
> Both applied to for-linus for v5.17, thank you!

Thanks for letting me know, Bjorn.

Best regards,
    Sergio Paracuellos