* [PATCH] ieee80211: cleanup double word in comment
@ 2022-01-25 18:07 trix
2022-01-25 18:19 ` Johannes Berg
2022-01-25 18:30 ` Joe Perches
0 siblings, 2 replies; 4+ messages in thread
From: trix @ 2022-01-25 18:07 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
Remove the second 'that'.
Signed-off-by: Tom Rix <trix@redhat.com>
---
include/linux/ieee80211.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index 559b6c6449384..5475383936f8b 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
static inline bool ieee80211_is_data_present(__le16 fc)
{
/*
- * mask with 0x40 and test that that bit is clear to only return true
+ * mask with 0x40 and test that bit is clear to only return true
* for the data-containing substypes.
*/
return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | 0x40)) ==
--
2.26.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ieee80211: cleanup double word in comment
2022-01-25 18:07 [PATCH] ieee80211: cleanup double word in comment trix
@ 2022-01-25 18:19 ` Johannes Berg
2022-01-25 20:03 ` Tom Rix
2022-01-25 18:30 ` Joe Perches
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2022-01-25 18:19 UTC (permalink / raw)
To: trix; +Cc: linux-wireless, linux-kernel
On Tue, 2022-01-25 at 10:07 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Remove the second 'that'.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> include/linux/ieee80211.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
> index 559b6c6449384..5475383936f8b 100644
> --- a/include/linux/ieee80211.h
> +++ b/include/linux/ieee80211.h
> @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
> static inline bool ieee80211_is_data_present(__le16 fc)
> {
> /*
> - * mask with 0x40 and test that that bit is clear to only return true
> + * mask with 0x40 and test that bit is clear to only return true
> * for the data-containing substypes.
>
I don't think it's just a duplicate?
... and (test that) (that bit is clear to ...)
no?
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ieee80211: cleanup double word in comment
2022-01-25 18:19 ` Johannes Berg
@ 2022-01-25 20:03 ` Tom Rix
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rix @ 2022-01-25 20:03 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, linux-kernel
On 1/25/22 10:19 AM, Johannes Berg wrote:
> On Tue, 2022-01-25 at 10:07 -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> Remove the second 'that'.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> include/linux/ieee80211.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
>> index 559b6c6449384..5475383936f8b 100644
>> --- a/include/linux/ieee80211.h
>> +++ b/include/linux/ieee80211.h
>> @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
>> static inline bool ieee80211_is_data_present(__le16 fc)
>> {
>> /*
>> - * mask with 0x40 and test that that bit is clear to only return true
>> + * mask with 0x40 and test that bit is clear to only return true
>> * for the data-containing substypes.
>>
> I don't think it's just a duplicate?
>
> ... and (test that) (that bit is clear to ...)
>
> no?
ok, reads ok.
Sorry for the noise.
T
>
> johannes
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ieee80211: cleanup double word in comment
2022-01-25 18:07 [PATCH] ieee80211: cleanup double word in comment trix
2022-01-25 18:19 ` Johannes Berg
@ 2022-01-25 18:30 ` Joe Perches
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2022-01-25 18:30 UTC (permalink / raw)
To: trix, johannes; +Cc: linux-wireless, linux-kernel
On Tue, 2022-01-25 at 10:07 -0800, trix@redhat.com wrote:
> Remove the second 'that'.
[]
> diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
[]
> @@ -467,7 +467,7 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
> static inline bool ieee80211_is_data_present(__le16 fc)
> {
> /*
> - * mask with 0x40 and test that that bit is clear to only return true
> + * mask with 0x40 and test that bit is clear to only return true
This is likely a false positive...
"that that" is frequently correct usage.
"that the" might be acceptable here instead.
Not sure about the "only" use though.
Maybe fix the substypes typo too.
---
include/linux/ieee80211.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h
index 559b6c6449384..0d9864adf9911 100644
--- a/include/linux/ieee80211.h
+++ b/include/linux/ieee80211.h
@@ -467,8 +467,8 @@ static inline bool ieee80211_is_data_qos(__le16 fc)
static inline bool ieee80211_is_data_present(__le16 fc)
{
/*
- * mask with 0x40 and test that that bit is clear to only return true
- * for the data-containing substypes.
+ * mask with 0x40 and test that the bit is clear to return true
+ * only for the data-containing subtypes.
*/
return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | 0x40)) ==
cpu_to_le16(IEEE80211_FTYPE_DATA);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-25 20:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 18:07 [PATCH] ieee80211: cleanup double word in comment trix
2022-01-25 18:19 ` Johannes Berg
2022-01-25 20:03 ` Tom Rix
2022-01-25 18:30 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome