* [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP
@ 2022-02-03 9:13 Thomas Zimmermann
2022-02-03 9:20 ` Arnd Bergmann
2022-02-03 21:05 ` Lyude Paul
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2022-02-03 9:13 UTC (permalink / raw)
To: thierry.reding, sam, airlied, daniel, lyude, linus.walleij,
dianders, ardb, naresh.kamboju
Cc: rdunlap, arnd, dri-devel, linux-kernel, Thomas Zimmermann,
Maarten Lankhorst, Maxime Ripard
As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
the option to fix the build failure. The issue has been reported
before, when DisplayPort helpers where hidden behind the option
CONFIG_DRM_KMS_HELPER. [2]
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper module")
Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 434c2861bb40..0aec5a10b064 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -106,6 +106,7 @@ config DRM_PANEL_EDP
depends on PM
select VIDEOMODE_HELPERS
select DRM_DP_AUX_BUS
+ select DRM_DP_HELPER
help
DRM panel driver for dumb eDP panels that need at most a regulator and
a GPIO to be powered up. Optionally a backlight can be attached so
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP
2022-02-03 9:13 [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP Thomas Zimmermann
@ 2022-02-03 9:20 ` Arnd Bergmann
2022-02-03 21:05 ` Lyude Paul
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2022-02-03 9:20 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Lyude Paul, Linus Walleij, Doug Anderson, Ard Biesheuvel,
Naresh Kamboju, Randy Dunlap, Arnd Bergmann, dri-devel,
Linux Kernel Mailing List, Maarten Lankhorst, Maxime Ripard
On Thu, Feb 3, 2022 at 10:13 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
> the option to fix the build failure. The issue has been reported
> before, when DisplayPort helpers where hidden behind the option
> CONFIG_DRM_KMS_HELPER. [2]
The two links [1] and [2] appear to be missing here, and I would also recommend
copying the build output into the changelog text for easier reference.
When linking to a bug report, best use 'Link:' tags in below.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper module")
> Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple")
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 434c2861bb40..0aec5a10b064 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -106,6 +106,7 @@ config DRM_PANEL_EDP
> depends on PM
> select VIDEOMODE_HELPERS
> select DRM_DP_AUX_BUS
> + select DRM_DP_HELPER
> help
> DRM panel driver for dumb eDP panels that need at most a regulator and
> a GPIO to be powered up. Optionally a backlight can be attached so
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP
2022-02-03 9:13 [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP Thomas Zimmermann
2022-02-03 9:20 ` Arnd Bergmann
@ 2022-02-03 21:05 ` Lyude Paul
1 sibling, 0 replies; 3+ messages in thread
From: Lyude Paul @ 2022-02-03 21:05 UTC (permalink / raw)
To: Thomas Zimmermann, thierry.reding, sam, airlied, daniel,
linus.walleij, dianders, ardb, naresh.kamboju
Cc: rdunlap, arnd, dri-devel, linux-kernel, Maarten Lankhorst, Maxime Ripard
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Thu, 2022-02-03 at 10:13 +0100, Thomas Zimmermann wrote:
> As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select
> the option to fix the build failure. The issue has been reported
> before, when DisplayPort helpers where hidden behind the option
> CONFIG_DRM_KMS_HELPER. [2]
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper
> module")
> Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple")
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 434c2861bb40..0aec5a10b064 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -106,6 +106,7 @@ config DRM_PANEL_EDP
> depends on PM
> select VIDEOMODE_HELPERS
> select DRM_DP_AUX_BUS
> + select DRM_DP_HELPER
> help
> DRM panel driver for dumb eDP panels that need at most a regulator
> and
> a GPIO to be powered up. Optionally a backlight can be attached so
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-03 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 9:13 [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP Thomas Zimmermann
2022-02-03 9:20 ` Arnd Bergmann
2022-02-03 21:05 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®