mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pinctrl: starfive: fix semicolon.cocci warnings
  2022-02-06  1:48 drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon kernel test robot
@ 2022-02-06  0:37 ` kernel test robot
  2022-02-06 23:58   ` Emil Renner Berthing
  2022-02-11  0:48   ` Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: kernel test robot @ 2022-02-06  0:37 UTC (permalink / raw)
  To: Emil Renner Berthing
  Cc: kbuild-all, linux-kernel, Andy Shevchenko, Linus Walleij,
	Huan Feng, Drew Fustini, linux-gpio

From: kernel test robot <lkp@intel.com>

drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: ec648f6b7686b716424e8e73eebb4c11ae199187 pinctrl: starfive: Add pinctrl driver for StarFive SoCs
:::::: branch date: 6 hours ago
:::::: commit date: 7 weeks ago

 pinctrl-starfive.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/pinctrl/pinctrl-starfive.c
+++ b/drivers/pinctrl/pinctrl-starfive.c
@@ -1026,7 +1026,7 @@ static int starfive_gpio_set_config(stru
 		break;
 	default:
 		return -ENOTSUPP;
-	};
+	}
 
 	starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio), mask, value);
 	return 0;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
@ 2022-02-06  1:48 kernel test robot
  2022-02-06  0:37 ` [PATCH] pinctrl: starfive: fix semicolon.cocci warnings kernel test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2022-02-06  1:48 UTC (permalink / raw)
  To: Emil Renner Berthing
  Cc: kbuild-all, linux-kernel, Andy Shevchenko, Linus Walleij,
	Huan Feng, Drew Fustini

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: ec648f6b7686b716424e8e73eebb4c11ae199187 pinctrl: starfive: Add pinctrl driver for StarFive SoCs
date:   7 weeks ago
config: riscv-randconfig-c003-20220206 (https://download.01.org/0day-ci/archive/20220206/202202060827.9dExlwbc-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings
  2022-02-06  0:37 ` [PATCH] pinctrl: starfive: fix semicolon.cocci warnings kernel test robot
@ 2022-02-06 23:58   ` Emil Renner Berthing
  2022-02-11  0:48   ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Emil Renner Berthing @ 2022-02-06 23:58 UTC (permalink / raw)
  To: kernel test robot
  Cc: kbuild-all, Linux Kernel Mailing List, Andy Shevchenko,
	Linus Walleij, Huan Feng, Drew Fustini, open list:GPIO SUBSYSTEM

On Sun, 6 Feb 2022 at 01:38, kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Thanks. There is already a previous patch for this although it was
sent before this code was in Linus' tree:
https://lore.kernel.org/all/20211222073522.123656-1-yang.lee@linux.alibaba.com/

/Emil

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings
  2022-02-06  0:37 ` [PATCH] pinctrl: starfive: fix semicolon.cocci warnings kernel test robot
  2022-02-06 23:58   ` Emil Renner Berthing
@ 2022-02-11  0:48   ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2022-02-11  0:48 UTC (permalink / raw)
  To: kernel test robot
  Cc: Emil Renner Berthing, kbuild-all, linux-kernel, Andy Shevchenko,
	Huan Feng, Drew Fustini, linux-gpio

On Sun, Feb 6, 2022 at 1:37 AM kernel test robot <lkp@intel.com> wrote:

> From: kernel test robot <lkp@intel.com>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Applied this patch and added the alibaba reporters as
Reported-by.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-11  0:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-06  1:48 drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon kernel test robot
2022-02-06  0:37 ` [PATCH] pinctrl: starfive: fix semicolon.cocci warnings kernel test robot
2022-02-06 23:58   ` Emil Renner Berthing
2022-02-11  0:48   ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome