* [PATCH] comedi: remove useless else if
@ 2022-02-07 10:31 Jiapeng Chong
0 siblings, 0 replies; only message in thread
From: Jiapeng Chong @ 2022-02-07 10:31 UTC (permalink / raw)
To: abbotti; +Cc: hsweeten, linux-kernel, Jiapeng Chong, Abaci Robot
Eliminate the follow coccicheck warning:
./drivers/comedi/drivers/das1800.c:1300:8-10: WARNING: possible
condition with no effect (if == else).
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/comedi/drivers/das1800.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/comedi/drivers/das1800.c b/drivers/comedi/drivers/das1800.c
index f09608c0f4ff..c4b6c68f3551 100644
--- a/drivers/comedi/drivers/das1800.c
+++ b/drivers/comedi/drivers/das1800.c
@@ -1297,14 +1297,13 @@ static int das1800_attach(struct comedi_device *dev,
outb(DAC(i), dev->iobase + DAS1800_SELECT);
outw(0, dev->iobase + DAS1800_DAC);
}
- } else if (board->id == DAS1800_ID_AO) {
+ } else {
/*
+ * the branch includes (board->id == DAS1800_ID_AO).
* 'ao' boards have waveform analog outputs that are not
* currently supported.
*/
s->type = COMEDI_SUBD_UNUSED;
- } else {
- s->type = COMEDI_SUBD_UNUSED;
}
/* Digital Input subdevice */
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-07 10:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 10:31 [PATCH] comedi: remove useless else if Jiapeng Chong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®