* [PATCH v1] Documentation: KUnit: Fix usage bug
@ 2022-02-07 11:20 Akira Kawata
2022-02-07 20:31 ` Brendan Higgins
0 siblings, 1 reply; 2+ messages in thread
From: Akira Kawata @ 2022-02-07 11:20 UTC (permalink / raw)
To: brendanhiggins
Cc: akirakawata1, Jonathan Corbet, linux-kselftest, kunit-dev,
linux-doc, linux-kernel
Fix a bug of kunit documentation.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=205773
: Quoting Steve Pfetsch:
:
: kunit documentation is incorrect:
: https://kunit.dev/third_party/stable_kernel/docs/usage.html
: struct rectangle *self = container_of(this, struct shape, parent);
:
:
: Shouldn't it be:
: struct rectangle *self = container_of(this, struct rectangle, parent);
: ?
Signed-off-by: Akira Kawata <akirakawata1@gmail.com>
---
Documentation/dev-tools/kunit/usage.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst
index 76af931a332c..1c83e7d60a8a 100644
--- a/Documentation/dev-tools/kunit/usage.rst
+++ b/Documentation/dev-tools/kunit/usage.rst
@@ -242,7 +242,7 @@ example:
int rectangle_area(struct shape *this)
{
- struct rectangle *self = container_of(this, struct shape, parent);
+ struct rectangle *self = container_of(this, struct rectangle, parent);
return self->length * self->width;
};
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1] Documentation: KUnit: Fix usage bug
2022-02-07 11:20 [PATCH v1] Documentation: KUnit: Fix usage bug Akira Kawata
@ 2022-02-07 20:31 ` Brendan Higgins
0 siblings, 0 replies; 2+ messages in thread
From: Brendan Higgins @ 2022-02-07 20:31 UTC (permalink / raw)
To: Akira Kawata
Cc: Jonathan Corbet, linux-kselftest, kunit-dev, linux-doc, linux-kernel
On Mon, Feb 7, 2022 at 6:21 AM Akira Kawata <akirakawata1@gmail.com> wrote:
>
> Fix a bug of kunit documentation.
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205773
>
> : Quoting Steve Pfetsch:
> :
> : kunit documentation is incorrect:
> : https://kunit.dev/third_party/stable_kernel/docs/usage.html
> : struct rectangle *self = container_of(this, struct shape, parent);
> :
> :
> : Shouldn't it be:
> : struct rectangle *self = container_of(this, struct rectangle, parent);
> : ?
>
> Signed-off-by: Akira Kawata <akirakawata1@gmail.com>
Wow. I can't believe we let this go for this long...and even after
doing an *almost* complete rewrite of that page.
Anyway, thanks for fixing this!
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-07 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 11:20 [PATCH v1] Documentation: KUnit: Fix usage bug Akira Kawata
2022-02-07 20:31 ` Brendan Higgins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®