From: Lina Wang <lina.wang@mediatek.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, <maze@google.com>,
<willemb@google.com>, <edumazet@google.com>,
<zhuoliang.zhang@mediatek.com>, <chao.song@mediatek.com>,
"lina . wang" <lina.wang@mediatek.com>
Subject: Re: [PATCH] net: fix wrong network header length
Date: Thu, 10 Feb 2022 19:56:34 +0800 [thread overview]
Message-ID: <20220210115634.18563-1-lina.wang@mediatek.com> (raw)
In-Reply-To: <20220209170610.10694339@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: lina.wang <lina.wang@mediatek.com>
On Wed, 2022-02-09 at 17:06 -0800, Jakub Kicinski wrote:
> On Wed, 9 Feb 2022 18:25:07 +0800 lina.wang wrote:
> > We use NETIF_F_GRO_FRAGLIST not for forwarding scenary, just for
> > software udp gro. Whatever NETIF_F_GRO_FRAGLIST or NETIF_F_GRO_FWD,
> > skb_segment_list should not have bugs.
> >
> > We modify skb_segment_list, not in epbf. One point is traversing
> > the
> > segments costly, another is what @Maciej said, *other* helper may
> > have
> > the same problem. In skb_segment_list, it calls
> > skb_headers_offset_update to update different headroom, which
> > implys
> > header maybe different.
>
> Process notes:
> - the patch didn't apply so even if the discussion concludes that
> the patch was good you'll need to rebase on netdev/net and repost;
> - please don't top post.
I have rebased and reposted--
https://patchwork.kernel.org/project/netdevbpf/patch/20220210091655.17231-1-lina.wang@mediatek.com/,
please check if it can apply.
Thanks!
next prev parent reply other threads:[~2022-02-10 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 2:55 Lina Wang
2022-02-08 8:25 ` Paolo Abeni
2022-02-08 12:57 ` Maciej Żenczykowski
2022-02-08 16:01 ` Paolo Abeni
[not found] ` <5ca86c46109794a627e6e2a62b140963217984a0.camel@mediatek.com>
2022-02-10 1:06 ` Jakub Kicinski
2022-02-10 11:56 ` Lina Wang [this message]
2022-02-10 16:02 ` Paolo Abeni
2022-02-10 18:06 ` Maciej Żenczykowski
2022-02-11 4:06 ` Lina Wang
2022-02-11 5:54 ` Maciej Żenczykowski
2022-02-16 12:52 ` Lina Wang
2022-02-10 7:49 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210115634.18563-1-lina.wang@mediatek.com \
--to=lina.wang@mediatek.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chao.song@mediatek.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=willemb@google.com \
--cc=yhs@fb.com \
--cc=zhuoliang.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®