From: Lina Wang <lina.wang@mediatek.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <bpf@vger.kernel.org>,
<maze@google.com>, Willem de Bruijn <willemb@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] net: fix wrong network header length
Date: Wed, 16 Feb 2022 20:52:48 +0800 [thread overview]
Message-ID: <20220216125248.24851-1-lina.wang@mediatek.com> (raw)
In-Reply-To: <d5dd3f10c144f7150ec508fa8e6d7a78ceabfc10.camel@redhat.com>
On Thu, 2022-02-10 at 17:02 +0100, Paolo Abeni wrote:
> On Wed, 2022-02-09 at 18:25 +0800, lina.wang wrote:
> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > index 75dfbde8d2e6..f15bbb7449ce 100644
> > --- a/net/core/skbuff.c
> > +++ b/net/core/skbuff.c
> > @@ -3682,6 +3682,7 @@ struct sk_buff *skb_segment_list(struct
> > sk_buff *skb,
> > struct sk_buff *tail = NULL;
> > struct sk_buff *nskb, *tmp;
> > int err;
> > + unsigned int len_diff = 0;
>
> Mintor nit: please respect the reverse x-mas tree order.
>
v3 has updated, please give some advice!
> >
> Paolo
>
Thanks!
next prev parent reply other threads:[~2022-02-16 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 2:55 Lina Wang
2022-02-08 8:25 ` Paolo Abeni
2022-02-08 12:57 ` Maciej Żenczykowski
2022-02-08 16:01 ` Paolo Abeni
[not found] ` <5ca86c46109794a627e6e2a62b140963217984a0.camel@mediatek.com>
2022-02-10 1:06 ` Jakub Kicinski
2022-02-10 11:56 ` Lina Wang
2022-02-10 16:02 ` Paolo Abeni
2022-02-10 18:06 ` Maciej Żenczykowski
2022-02-11 4:06 ` Lina Wang
2022-02-11 5:54 ` Maciej Żenczykowski
2022-02-16 12:52 ` Lina Wang [this message]
2022-02-10 7:49 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216125248.24851-1-lina.wang@mediatek.com \
--to=lina.wang@mediatek.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®