* [PATCH net] net: ipa: add an interconnect dependency
@ 2022-02-26 19:57 Alex Elder
2022-03-01 5:35 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Alex Elder @ 2022-02-26 19:57 UTC (permalink / raw)
To: davem, kuba
Cc: bjorn.andersson, mka, evgreen, cpratapa, avuyyuru, jponduru,
subashab, elder, lkp, netdev, linux-arm-msm, linux-kernel
In order to function, the IPA driver very clearly requires the
interconnect framework to be enabled in the kernel configuration.
State that dependency in the Kconfig file.
This became a problem when CONFIG_COMPILE_TEST support was added.
Non-Qualcomm platforms won't necessarily enable CONFIG_INTERCONNECT.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST")
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
index d037682fb7adb..3e0da1e764718 100644
--- a/drivers/net/ipa/Kconfig
+++ b/drivers/net/ipa/Kconfig
@@ -2,6 +2,7 @@ config QCOM_IPA
tristate "Qualcomm IPA support"
depends on NET && QCOM_SMEM
depends on ARCH_QCOM || COMPILE_TEST
+ depends on INTERCONNECT
depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
select QCOM_MDT_LOADER if ARCH_QCOM
select QCOM_SCM
--
2.32.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: ipa: add an interconnect dependency
2022-02-26 19:57 [PATCH net] net: ipa: add an interconnect dependency Alex Elder
@ 2022-03-01 5:35 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-03-01 5:35 UTC (permalink / raw)
To: Alex Elder
Cc: davem, bjorn.andersson, mka, evgreen, cpratapa, avuyyuru,
jponduru, subashab, elder, lkp, netdev, linux-arm-msm,
linux-kernel
On Sat, 26 Feb 2022 13:57:47 -0600 Alex Elder wrote:
> In order to function, the IPA driver very clearly requires the
> interconnect framework to be enabled in the kernel configuration.
> State that dependency in the Kconfig file.
>
> This became a problem when CONFIG_COMPILE_TEST support was added.
> Non-Qualcomm platforms won't necessarily enable CONFIG_INTERCONNECT.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST")
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index d037682fb7adb..3e0da1e764718 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -2,6 +2,7 @@ config QCOM_IPA
> tristate "Qualcomm IPA support"
> depends on NET && QCOM_SMEM
> depends on ARCH_QCOM || COMPILE_TEST
> + depends on INTERCONNECT
> depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
> select QCOM_MDT_LOADER if ARCH_QCOM
> select QCOM_SCM
Looks like this patch was based on a tree without the QCOM_AOSS_QMP
dependency patch, please rebase and repost.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-01 5:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-26 19:57 [PATCH net] net: ipa: add an interconnect dependency Alex Elder
2022-03-01 5:35 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®