* [PATCH] drm/sun4i: mixer: Fix P010 and P210 format numbers
@ 2022-02-28 18:14 Jernej Skrabec
2022-03-08 10:56 ` (subset) " Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Jernej Skrabec @ 2022-02-28 18:14 UTC (permalink / raw)
To: mripard, wens
Cc: samuel, airlied, daniel, dri-devel, linux-arm-kernel,
linux-sunxi, linux-kernel, Jernej Skrabec
It turns out that DE3 manual has inverted YUV and YVU format numbers for
P010 and P210. Invert them.
This was tested by playing video decoded to P010 and additionally
confirmed by looking at BSP driver source.
Fixes: 169ca4b38932 ("drm/sun4i: Add separate DE3 VI layer formats")
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
drivers/gpu/drm/sun4i/sun8i_mixer.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h b/drivers/gpu/drm/sun4i/sun8i_mixer.h
index 145833a9d82d..5b3fbee18671 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.h
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h
@@ -111,10 +111,10 @@
/* format 13 is semi-planar YUV411 VUVU */
#define SUN8I_MIXER_FBFMT_YUV411 14
/* format 15 doesn't exist */
-/* format 16 is P010 YVU */
-#define SUN8I_MIXER_FBFMT_P010_YUV 17
-/* format 18 is P210 YVU */
-#define SUN8I_MIXER_FBFMT_P210_YUV 19
+#define SUN8I_MIXER_FBFMT_P010_YUV 16
+/* format 17 is P010 YVU */
+#define SUN8I_MIXER_FBFMT_P210_YUV 18
+/* format 19 is P210 YVU */
/* format 20 is packed YVU444 10-bit */
/* format 21 is packed YUV444 10-bit */
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] drm/sun4i: mixer: Fix P010 and P210 format numbers
2022-02-28 18:14 [PATCH] drm/sun4i: mixer: Fix P010 and P210 format numbers Jernej Skrabec
@ 2022-03-08 10:56 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2022-03-08 10:56 UTC (permalink / raw)
To: Jernej Skrabec, mripard, wens
Cc: Maxime Ripard, airlied, samuel, linux-arm-kernel, dri-devel,
daniel, linux-kernel, linux-sunxi
On Mon, 28 Feb 2022 19:14:36 +0100, Jernej Skrabec wrote:
> It turns out that DE3 manual has inverted YUV and YVU format numbers for
> P010 and P210. Invert them.
>
> This was tested by playing video decoded to P010 and additionally
> confirmed by looking at BSP driver source.
>
>
> [...]
Applied to drm/drm-misc (drm-misc-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-08 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 18:14 [PATCH] drm/sun4i: mixer: Fix P010 and P210 format numbers Jernej Skrabec
2022-03-08 10:56 ` (subset) " Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®