* [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()
@ 2022-03-01 8:16 Yang Li
2022-03-03 9:29 ` Adam Thomson
2022-03-04 21:13 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2022-03-01 8:16 UTC (permalink / raw)
To: sre; +Cc: support.opensource, linux-pm, linux-kernel, Yang Li, Abaci Robot
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.
Eliminate the follow coccicheck warning:
./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/power/supply/da9150-fg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
index e63fa62d1943..8c5e2c49d6c1 100644
--- a/drivers/power/supply/da9150-fg.c
+++ b/drivers/power/supply/da9150-fg.c
@@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
/* Register IRQ */
irq = platform_get_irq_byname(pdev, "FG");
- if (irq < 0) {
- dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
+ if (irq < 0)
return irq;
- }
ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
IRQF_ONESHOT, "FG", fg);
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()
2022-03-01 8:16 [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err() Yang Li
@ 2022-03-03 9:29 ` Adam Thomson
2022-03-04 21:13 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Adam Thomson @ 2022-03-03 9:29 UTC (permalink / raw)
To: Yang Li, sre; +Cc: Support Opensource, linux-pm, linux-kernel, Abaci Robot
On 01 March 2022 08:16, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()
2022-03-01 8:16 [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err() Yang Li
2022-03-03 9:29 ` Adam Thomson
@ 2022-03-04 21:13 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2022-03-04 21:13 UTC (permalink / raw)
To: Yang Li; +Cc: support.opensource, linux-pm, linux-kernel, Abaci Robot
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
Hi,
On Tue, Mar 01, 2022 at 04:16:19PM +0800, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/da9150-fg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
> index e63fa62d1943..8c5e2c49d6c1 100644
> --- a/drivers/power/supply/da9150-fg.c
> +++ b/drivers/power/supply/da9150-fg.c
> @@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
>
> /* Register IRQ */
> irq = platform_get_irq_byname(pdev, "FG");
> - if (irq < 0) {
> - dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
> IRQF_ONESHOT, "FG", fg);
> --
> 2.20.1.7.g153144c
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-04 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 8:16 [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err() Yang Li
2022-03-03 9:29 ` Adam Thomson
2022-03-04 21:13 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®