mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: mingo@redhat.com, peterz@infradead.org, frederic@kernel.org,
	tglx@linutronix.de, mtosatti@redhat.com, bristot@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] sched/isolation: use raw_smp_processor_id() in housekeeping_any_cpu()
Date: Tue, 1 Mar 2022 10:10:28 -0500	[thread overview]
Message-ID: <20220301101028.1f510bf5@gandalf.local.home> (raw)
In-Reply-To: <20220301113053.141514-1-nsaenzju@redhat.com>

On Tue,  1 Mar 2022 12:30:52 +0100
Nicolas Saenz Julienne <nsaenzju@redhat.com> wrote:

> housekeeping_any_cpu() will return a housekeeping CPU. That's it. It'll
> try to optimize for NUMA locality and to use the local CPU, but it's not
> a requisite.
> 
> So let's use raw_smp_processor_id() instead of its vanilla counterpart
> in order to allow users to query for housekeeping CPUs without having to
> disable preemption.

Peter, care to ACK this, and I can take it through my tree?

-- Steve

> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> ---
>  include/linux/sched/isolation.h | 2 +-
>  kernel/sched/isolation.c        | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h
> index 8c15abd67aed..0c09ff1e4599 100644
> --- a/include/linux/sched/isolation.h
> +++ b/include/linux/sched/isolation.h
> @@ -31,7 +31,7 @@ extern void __init housekeeping_init(void);
>  
>  static inline int housekeeping_any_cpu(enum hk_type type)
>  {
> -	return smp_processor_id();
> +	return raw_smp_processor_id();
>  }
>  
>  static inline const struct cpumask *housekeeping_cpumask(enum hk_type type)
> diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c
> index b4d10815c45a..c2c1f6d8bb5f 100644
> --- a/kernel/sched/isolation.c
> +++ b/kernel/sched/isolation.c
> @@ -43,14 +43,14 @@ int housekeeping_any_cpu(enum hk_type type)
>  
>  	if (static_branch_unlikely(&housekeeping_overridden)) {
>  		if (housekeeping.flags & BIT(type)) {
> -			cpu = sched_numa_find_closest(housekeeping.cpumasks[type], smp_processor_id());
> +			cpu = sched_numa_find_closest(housekeeping.cpumasks[type], raw_smp_processor_id());
>  			if (cpu < nr_cpu_ids)
>  				return cpu;
>  
>  			return cpumask_any_and(housekeeping.cpumasks[type], cpu_online_mask);
>  		}
>  	}
> -	return smp_processor_id();
> +	return raw_smp_processor_id();
>  }
>  EXPORT_SYMBOL_GPL(housekeeping_any_cpu);
>  


  parent reply	other threads:[~2022-03-01 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 11:30 Nicolas Saenz Julienne
2022-03-01 11:30 ` [PATCH v2 2/2] tracing: Avoid isolated CPUs when queueing fsnotify irqwork Nicolas Saenz Julienne
2022-03-01 18:58   ` Daniel Bristot de Oliveira
2022-03-01 15:10 ` Steven Rostedt [this message]
2022-03-01 18:57 ` [PATCH v2 1/2] sched/isolation: use raw_smp_processor_id() in housekeeping_any_cpu() Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301101028.1f510bf5@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=bristot@redhat.com \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=nsaenzju@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®