From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>,
mingo@redhat.com, peterz@infradead.org, frederic@kernel.org,
rostedt@goodmis.org
Cc: tglx@linutronix.de, mtosatti@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tracing: Avoid isolated CPUs when queueing fsnotify irqwork
Date: Tue, 1 Mar 2022 19:58:23 +0100 [thread overview]
Message-ID: <b823e468-3c98-44d8-ccf6-8a9ddc769fb5@redhat.com> (raw)
In-Reply-To: <20220301113053.141514-2-nsaenzju@redhat.com>
On 3/1/22 12:30, Nicolas Saenz Julienne wrote:
> There isn't any need for this irq_work to be run locally, so avoid doing
> so when the CPU is isolated.
>
> Note that this is especially bad as queueing it into a local isolated
> CPU might add noise to what was meant to be traced in the first place.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@kernel.org>
-- Daniel
next prev parent reply other threads:[~2022-03-01 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:30 [PATCH v2 1/2] sched/isolation: use raw_smp_processor_id() in housekeeping_any_cpu() Nicolas Saenz Julienne
2022-03-01 11:30 ` [PATCH v2 2/2] tracing: Avoid isolated CPUs when queueing fsnotify irqwork Nicolas Saenz Julienne
2022-03-01 18:58 ` Daniel Bristot de Oliveira [this message]
2022-03-01 15:10 ` [PATCH v2 1/2] sched/isolation: use raw_smp_processor_id() in housekeeping_any_cpu() Steven Rostedt
2022-03-01 18:57 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b823e468-3c98-44d8-ccf6-8a9ddc769fb5@redhat.com \
--to=bristot@redhat.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®