mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Jon Lin <jon.lin@rock-chips.com>, Mark Brown <broonie@kernel.org>,
	Sasha Levin <sashal@kernel.org>,
	heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: [PATCH AUTOSEL 5.10 04/14] spi: rockchip: terminate dma transmission when slave abort
Date: Tue,  1 Mar 2022 15:18:16 -0500	[thread overview]
Message-ID: <20220301201833.18841-4-sashal@kernel.org> (raw)
In-Reply-To: <20220301201833.18841-1-sashal@kernel.org>

From: Jon Lin <jon.lin@rock-chips.com>

[ Upstream commit 80808768e41324d2e23de89972b5406c1020e6e4 ]

After slave abort, all DMA should be stopped, or it will affect the
next transmission and maybe abort again.

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
Link: https://lore.kernel.org/r/20220216014028.8123-3-jon.lin@rock-chips.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/spi/spi-rockchip.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index a594310754111..a9f97023d5a00 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -567,6 +567,12 @@ static int rockchip_spi_slave_abort(struct spi_controller *ctlr)
 {
 	struct rockchip_spi *rs = spi_controller_get_devdata(ctlr);
 
+	if (atomic_read(&rs->state) & RXDMA)
+		dmaengine_terminate_sync(ctlr->dma_rx);
+	if (atomic_read(&rs->state) & TXDMA)
+		dmaengine_terminate_sync(ctlr->dma_tx);
+	atomic_set(&rs->state, 0);
+	spi_enable_chip(rs, false);
 	rs->slave_abort = true;
 	complete(&ctlr->xfer_completion);
 
-- 
2.34.1


  parent reply	other threads:[~2022-03-01 20:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 20:18 [PATCH AUTOSEL 5.10 01/14] selftests/bpf: Add test for bpf_timer overwriting crash Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 02/14] KVM: Fix lockdep false negative during host resume Sasha Levin
2022-03-01 20:19   ` Paolo Bonzini
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 03/14] spi: rockchip: Fix error in getting num-cs property Sasha Levin
2022-03-01 20:18 ` Sasha Levin [this message]
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 05/14] net-sysfs: add check for netdevice being present to speed_show Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 06/14] sr9700: sanity check for packet length Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 07/14] hwmon: (pmbus) Clear pmbus fault/warning bits after read Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 08/14] gpio: Return EPROBE_DEFER if gc->to_irq is NULL Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 09/14] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 10/14] Revert "xen-netback: Check for hotplug-status existence before watching" Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 11/14] ipv6: prevent a possible race condition with lifetimes Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 12/14] tracing: Ensure trace buffer is at least 4096 bytes large Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 13/14] selftest/vm: fix map_fixed_noreplace test failure Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 14/14] selftests/memfd: clean up mapping in mfd_fail_write Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301201833.18841-4-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=jon.lin@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome