From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Vikash Chandola <vikash.chandola@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Sasha Levin <sashal@kernel.org>,
jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 5.10 07/14] hwmon: (pmbus) Clear pmbus fault/warning bits after read
Date: Tue, 1 Mar 2022 15:18:19 -0500 [thread overview]
Message-ID: <20220301201833.18841-7-sashal@kernel.org> (raw)
In-Reply-To: <20220301201833.18841-1-sashal@kernel.org>
From: Vikash Chandola <vikash.chandola@linux.intel.com>
[ Upstream commit 35f165f08950a876f1b95a61d79c93678fba2fd6 ]
Almost all fault/warning bits in pmbus status registers remain set even
after fault/warning condition are removed. As per pmbus specification
these faults must be cleared by user.
Modify hwmon behavior to clear fault/warning bit after fetching data if
fault/warning bit was set. This allows to get fresh data in next read.
Signed-off-by: Vikash Chandola <vikash.chandola@linux.intel.com>
Link: https://lore.kernel.org/r/20220222131253.2426834-1-vikash.chandola@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/hwmon/pmbus/pmbus_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index b0e2820a2d578..71798fde2ef0c 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -898,6 +898,11 @@ static int pmbus_get_boolean(struct i2c_client *client, struct pmbus_boolean *b,
pmbus_update_sensor_data(client, s2);
regval = status & mask;
+ if (regval) {
+ ret = pmbus_write_byte_data(client, page, reg, regval);
+ if (ret)
+ goto unlock;
+ }
if (s1 && s2) {
s64 v1, v2;
--
2.34.1
next prev parent reply other threads:[~2022-03-01 20:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 20:18 [PATCH AUTOSEL 5.10 01/14] selftests/bpf: Add test for bpf_timer overwriting crash Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 02/14] KVM: Fix lockdep false negative during host resume Sasha Levin
2022-03-01 20:19 ` Paolo Bonzini
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 03/14] spi: rockchip: Fix error in getting num-cs property Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 04/14] spi: rockchip: terminate dma transmission when slave abort Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 05/14] net-sysfs: add check for netdevice being present to speed_show Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 06/14] sr9700: sanity check for packet length Sasha Levin
2022-03-01 20:18 ` Sasha Levin [this message]
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 08/14] gpio: Return EPROBE_DEFER if gc->to_irq is NULL Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 09/14] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose" Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 10/14] Revert "xen-netback: Check for hotplug-status existence before watching" Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 11/14] ipv6: prevent a possible race condition with lifetimes Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 12/14] tracing: Ensure trace buffer is at least 4096 bytes large Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 13/14] selftest/vm: fix map_fixed_noreplace test failure Sasha Levin
2022-03-01 20:18 ` [PATCH AUTOSEL 5.10 14/14] selftests/memfd: clean up mapping in mfd_fail_write Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301201833.18841-7-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
--cc=vikash.chandola@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome