* [PATCH] scsi: sr: Simplify ptr_min_max_vals adjustment
@ 2022-03-03 8:57 Meng Tang
0 siblings, 0 replies; only message in thread
From: Meng Tang @ 2022-03-03 8:57 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, Meng Tang
When the med->media_event_code value is equal to 2 or 3, the
same value is returned, so it would be better to combine the
implementation statements when the med->media_event_code value
is equal to 2 or 3.
Moreover, when a variable is equal to multiple values, it is
better to use a switch judgment statement.
Signed-off-by: Meng Tang <tangmeng@uniontech.com>
---
drivers/scsi/sr.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
index f925b1f1f9ad..610baa630067 100644
--- a/drivers/scsi/sr.c
+++ b/drivers/scsi/sr.c
@@ -222,12 +222,16 @@ static unsigned int sr_get_events(struct scsi_device *sdev)
if (eh->nea || eh->notification_class != 0x4)
return 0;
- if (med->media_event_code == 1)
+ switch (med->media_event_code) {
+ case 1:
return DISK_EVENT_EJECT_REQUEST;
- else if (med->media_event_code == 2)
- return DISK_EVENT_MEDIA_CHANGE;
- else if (med->media_event_code == 3)
+ case 2:
+ case 3:
return DISK_EVENT_MEDIA_CHANGE;
+ default:
+ break;
+ }
+
return 0;
}
--
2.20.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-03-03 8:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 8:57 [PATCH] scsi: sr: Simplify ptr_min_max_vals adjustment Meng Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®