* [PATCH] mwifiex: make read-only array wmm_oui static const
@ 2022-03-11 22:56 Colin Ian King
2022-03-16 15:28 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-03-11 22:56 UTC (permalink / raw)
To: Amitkumar Karwar, Ganapathi Bhat, Sharvari Harisangam,
Xinming Hu, Kalle Valo, David S . Miller, Jakub Kicinski,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
Don't populate the read-only array wmm_oui on the stack but
instead make it static const. Also makes the object code a little
smaller.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/marvell/mwifiex/uap_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
index 18e89777b784..630e1679c3f9 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
@@ -389,7 +389,7 @@ mwifiex_set_wmm_params(struct mwifiex_private *priv,
{
const u8 *vendor_ie;
const u8 *wmm_ie;
- u8 wmm_oui[] = {0x00, 0x50, 0xf2, 0x02};
+ static const u8 wmm_oui[] = {0x00, 0x50, 0xf2, 0x02};
vendor_ie = cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
WLAN_OUI_TYPE_MICROSOFT_WMM,
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mwifiex: make read-only array wmm_oui static const
2022-03-11 22:56 [PATCH] mwifiex: make read-only array wmm_oui static const Colin Ian King
@ 2022-03-16 15:28 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-03-16 15:28 UTC (permalink / raw)
To: Colin Ian King
Cc: Amitkumar Karwar, Ganapathi Bhat, Sharvari Harisangam,
Xinming Hu, David S . Miller, Jakub Kicinski, linux-wireless,
netdev, kernel-janitors, linux-kernel
Colin Ian King <colin.i.king@gmail.com> wrote:
> Don't populate the read-only array wmm_oui on the stack but
> instead make it static const. Also makes the object code a little
> smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Patch applied to wireless-next.git, thanks.
e7d1fc0b5ff2 mwifiex: make read-only array wmm_oui static const
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220311225610.10895-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 22:56 [PATCH] mwifiex: make read-only array wmm_oui static const Colin Ian King
2022-03-16 15:28 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®