* [PATCH] nfsd: use correct format characters
@ 2022-03-16 21:31 Bill Wendling
2022-03-17 6:09 ` Randy Dunlap
2022-03-17 18:42 ` [PATCH v2] " Bill Wendling
0 siblings, 2 replies; 6+ messages in thread
From: Bill Wendling @ 2022-03-16 21:31 UTC (permalink / raw)
To: Chuck Lever, Nathan Chancellor, Nick Desaulniers, linux-nfs,
linux-kernel, llvm
Cc: Bill Wendling
When compiling with -Wformat, clang emits the following warnings:
fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
"%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
~~~~ ^~~~~~~~~
%d
fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
"%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
~~~~ ^~~~~~~~~~~
%d
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: ClangBuiltLinux/linux#378
Signed-off-by: Bill Wendling <morbo@google.com>
---
fs/nfsd/flexfilelayout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
index 2e2f1d5e9f62..070f90ed09b6 100644
--- a/fs/nfsd/flexfilelayout.c
+++ b/fs/nfsd/flexfilelayout.c
@@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
da->netaddr.addr_len =
snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
- "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
+ "%s.%d.%d", addr, port >> 8, port & 0xff);
da->tightly_coupled = false;
--
2.35.1.723.g4982287a31-goog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] nfsd: use correct format characters
2022-03-16 21:31 [PATCH] nfsd: use correct format characters Bill Wendling
@ 2022-03-17 6:09 ` Randy Dunlap
2022-03-17 18:42 ` Bill Wendling
2022-03-17 18:42 ` [PATCH v2] " Bill Wendling
1 sibling, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2022-03-17 6:09 UTC (permalink / raw)
To: Bill Wendling, Chuck Lever, Nathan Chancellor, Nick Desaulniers,
linux-nfs, linux-kernel, llvm
Hi--
On 3/16/22 14:31, Bill Wendling wrote:
> When compiling with -Wformat, clang emits the following warnings:
>
> fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
> char' but the argument has type 'int' [-Wformat]
> "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> ~~~~ ^~~~~~~~~
> %d
> fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
> char' but the argument has type 'int' [-Wformat]
> "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> ~~~~ ^~~~~~~~~~~
> %d
>
> The types of these arguments are unconditionally defined, so this patch
> updates the format character to the correct ones for ints and unsigned
> ints.
>
> Link: ClangBuiltLinux/linux#378
Please make the Link: more complete, such as a URL/URI.
> Signed-off-by: Bill Wendling <morbo@google.com>
> ---
> fs/nfsd/flexfilelayout.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
> index 2e2f1d5e9f62..070f90ed09b6 100644
> --- a/fs/nfsd/flexfilelayout.c
> +++ b/fs/nfsd/flexfilelayout.c
> @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
>
> da->netaddr.addr_len =
> snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
> - "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> + "%s.%d.%d", addr, port >> 8, port & 0xff);
>
> da->tightly_coupled = false;
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfsd: use correct format characters
2022-03-17 6:09 ` Randy Dunlap
@ 2022-03-17 18:42 ` Bill Wendling
0 siblings, 0 replies; 6+ messages in thread
From: Bill Wendling @ 2022-03-17 18:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Chuck Lever, Nathan Chancellor, Nick Desaulniers, linux-nfs, LKML, llvm
On Wed, Mar 16, 2022 at 11:09 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi--
>
> On 3/16/22 14:31, Bill Wendling wrote:
> > When compiling with -Wformat, clang emits the following warnings:
> >
> > fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
> > char' but the argument has type 'int' [-Wformat]
> > "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> > ~~~~ ^~~~~~~~~
> > %d
> > fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
> > char' but the argument has type 'int' [-Wformat]
> > "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> > ~~~~ ^~~~~~~~~~~
> > %d
> >
> > The types of these arguments are unconditionally defined, so this patch
> > updates the format character to the correct ones for ints and unsigned
> > ints.
> >
> > Link: ClangBuiltLinux/linux#378
>
> Please make the Link: more complete, such as a URL/URI.
>
Done. I sent out v2 of the patch. Sorry about this oversight!
-bw
> > Signed-off-by: Bill Wendling <morbo@google.com>
> > ---
> > fs/nfsd/flexfilelayout.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
> > index 2e2f1d5e9f62..070f90ed09b6 100644
> > --- a/fs/nfsd/flexfilelayout.c
> > +++ b/fs/nfsd/flexfilelayout.c
> > @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
> >
> > da->netaddr.addr_len =
> > snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
> > - "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> > + "%s.%d.%d", addr, port >> 8, port & 0xff);
> >
> > da->tightly_coupled = false;
> >
>
> thanks.
> --
> ~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] nfsd: use correct format characters
2022-03-16 21:31 [PATCH] nfsd: use correct format characters Bill Wendling
2022-03-17 6:09 ` Randy Dunlap
@ 2022-03-17 18:42 ` Bill Wendling
2022-03-17 19:02 ` Chuck Lever III
[not found] ` <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>
1 sibling, 2 replies; 6+ messages in thread
From: Bill Wendling @ 2022-03-17 18:42 UTC (permalink / raw)
To: Chuck Lever, Nathan Chancellor, Nick Desaulniers, linux-nfs,
linux-kernel, llvm
Cc: Bill Wendling
When compiling with -Wformat, clang emits the following warnings:
fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
"%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
~~~~ ^~~~~~~~~
%d
fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
char' but the argument has type 'int' [-Wformat]
"%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
~~~~ ^~~~~~~~~~~
%d
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <morbo@google.com>
---
v2 - Fixed "Link" to be a valid URL.
---
fs/nfsd/flexfilelayout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
index 2e2f1d5e9f62..070f90ed09b6 100644
--- a/fs/nfsd/flexfilelayout.c
+++ b/fs/nfsd/flexfilelayout.c
@@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
da->netaddr.addr_len =
snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
- "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
+ "%s.%d.%d", addr, port >> 8, port & 0xff);
da->tightly_coupled = false;
--
2.35.1.723.g4982287a31-goog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] nfsd: use correct format characters
2022-03-17 18:42 ` [PATCH v2] " Bill Wendling
@ 2022-03-17 19:02 ` Chuck Lever III
[not found] ` <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>
1 sibling, 0 replies; 6+ messages in thread
From: Chuck Lever III @ 2022-03-17 19:02 UTC (permalink / raw)
To: Thomas Haynes
Cc: Nathan Chancellor, Nick Desaulniers, Linux NFS Mailing List,
Linux Kernel Mailing List, llvm, Bill Wendling
> On Mar 17, 2022, at 2:42 PM, Bill Wendling <morbo@google.com> wrote:
>
> When compiling with -Wformat, clang emits the following warnings:
>
> fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
> char' but the argument has type 'int' [-Wformat]
> "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> ~~~~ ^~~~~~~~~
> %d
> fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
> char' but the argument has type 'int' [-Wformat]
> "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> ~~~~ ^~~~~~~~~~~
> %d
>
> The types of these arguments are unconditionally defined, so this patch
> updates the format character to the correct ones for ints and unsigned
> ints.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Bill Wendling <morbo@google.com>
> ---
> v2 - Fixed "Link" to be a valid URL.
Hi Tom, can I get a Reviewed-by from you?
> ---
> fs/nfsd/flexfilelayout.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
> index 2e2f1d5e9f62..070f90ed09b6 100644
> --- a/fs/nfsd/flexfilelayout.c
> +++ b/fs/nfsd/flexfilelayout.c
> @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
>
> da->netaddr.addr_len =
> snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
> - "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> + "%s.%d.%d", addr, port >> 8, port & 0xff);
>
> da->tightly_coupled = false;
>
> --
> 2.35.1.723.g4982287a31-goog
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>]
* Re: [PATCH v2] nfsd: use correct format characters
[not found] ` <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>
@ 2022-03-17 23:47 ` Chuck Lever III
0 siblings, 0 replies; 6+ messages in thread
From: Chuck Lever III @ 2022-03-17 23:47 UTC (permalink / raw)
To: Thomas Haynes
Cc: Bill Wendling, Nathan Chancellor, Nick Desaulniers,
Linux NFS Mailing List, linux-kernel, llvm
> On Mar 17, 2022, at 7:45 PM, Thomas Haynes <loghyr@hammerspace.com> wrote:
>
>
>
>> On Mar 17, 2022, at 11:42 AM, Bill Wendling <morbo@google.com> wrote:
>>
>> [You don't often get email from morbo@google.com. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.]
>>
>> When compiling with -Wformat, clang emits the following warnings:
>>
>> fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
>> char' but the argument has type 'int' [-Wformat]
>> "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>> ~~~~ ^~~~~~~~~
>> %d
>> fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
>> char' but the argument has type 'int' [-Wformat]
>> "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>> ~~~~ ^~~~~~~~~~~
>> %d
>>
>> The types of these arguments are unconditionally defined, so this patch
>> updates the format character to the correct ones for ints and unsigned
>> ints.
>>
>> Link: https://github.com/ClangBuiltLinux/linux/issues/378
>> Signed-off-by: Bill Wendling <morbo@google.com>
>> ---
>> v2 - Fixed "Link" to be a valid URL.
>> ---
>> fs/nfsd/flexfilelayout.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
>> index 2e2f1d5e9f62..070f90ed09b6 100644
>> --- a/fs/nfsd/flexfilelayout.c
>> +++ b/fs/nfsd/flexfilelayout.c
>> @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
>>
>> da->netaddr.addr_len =
>> snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
>> - "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>> + "%s.%d.%d", addr, port >> 8, port & 0xff);
>>
>> da->tightly_coupled = false;
>>
>> --
>> 2.35.1.723.g4982287a31-goog
>>
>
>
> Reviewed-by: Tom Haynes <loghyr@hammerspace.com>
Perfect, thanks!
--
Chuck Lever
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-17 23:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-16 21:31 [PATCH] nfsd: use correct format characters Bill Wendling
2022-03-17 6:09 ` Randy Dunlap
2022-03-17 18:42 ` Bill Wendling
2022-03-17 18:42 ` [PATCH v2] " Bill Wendling
2022-03-17 19:02 ` Chuck Lever III
[not found] ` <BEEEADA0-C8E6-44E5-A350-09F35662436B@hammerspace.com>
2022-03-17 23:47 ` Chuck Lever III
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®