mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	tan.shaopeng@jp.fujitsu.com,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: [PATCH v6 1/6] selftests/resctrl: Kill child process before parent process terminates if SIGTERM is received
Date: Fri, 18 Mar 2022 16:58:02 +0900	[thread overview]
Message-ID: <20220318075807.2921063-2-tan.shaopeng@jp.fujitsu.com> (raw)
In-Reply-To: <20220318075807.2921063-1-tan.shaopeng@jp.fujitsu.com>

In kselftest framework, a sub test is run using the timeout utility
and it will send SIGTERM to the test upon timeout.

In resctrl_tests, a child process is created by fork() to
run benchmark but SIGTERM is not set in sigaction().
If SIGTERM signal is received, the parent process will be killed,
but the child process still exists.

kill child process before parent process terminates
if SIGTERM signal is received.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
---
 tools/testing/selftests/resctrl/resctrl_val.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
index 95224345c78e..b32b96356ec7 100644
--- a/tools/testing/selftests/resctrl/resctrl_val.c
+++ b/tools/testing/selftests/resctrl/resctrl_val.c
@@ -678,6 +678,7 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param)
 	sigemptyset(&sigact.sa_mask);
 	sigact.sa_flags = SA_SIGINFO;
 	if (sigaction(SIGINT, &sigact, NULL) ||
+	    sigaction(SIGTERM, &sigact, NULL) ||
 	    sigaction(SIGHUP, &sigact, NULL)) {
 		perror("# sigaction");
 		ret = errno;
-- 
2.27.0


  reply	other threads:[~2022-03-18  7:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18  7:58 [PATCH v6 0/6] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2022-03-18  7:58 ` Shaopeng Tan [this message]
2022-03-18 22:47   ` [PATCH v6 1/6] selftests/resctrl: Kill child process before parent process terminates if SIGTERM is received Fenghua Yu
2022-03-18  7:58 ` [PATCH v6 2/6] selftests/resctrl: Change the default limited time to 120 seconds Shaopeng Tan
2022-03-18 22:48   ` Fenghua Yu
2022-03-18  7:58 ` [PATCH v6 3/6] selftests/resctrl: Fix resctrl_tests' return code to work with selftest framework Shaopeng Tan
2022-03-18 20:58   ` Reinette Chatre
2022-03-18 22:51   ` Fenghua Yu
2022-03-18  7:58 ` [PATCH v6 4/6] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2022-03-18 20:59   ` Reinette Chatre
2022-03-18 22:55   ` Fenghua Yu
2022-03-18  7:58 ` [PATCH v6 5/6] selftests/resctrl: Update README about using kselftest framework to build/run resctrl_tests Shaopeng Tan
2022-03-18 20:59   ` Reinette Chatre
2022-03-18 22:57   ` Fenghua Yu
2022-03-18  7:58 ` [PATCH v6 6/6] selftests/resctrl: Add missing SPDX license to Makefile Shaopeng Tan
2022-03-18 21:00   ` Reinette Chatre
2022-03-18 22:58   ` Fenghua Yu
2022-03-18 21:00 ` [PATCH v6 0/6] selftests/resctrl: Add resctrl_tests into kselftest set Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318075807.2921063-2-tan.shaopeng@jp.fujitsu.com \
    --to=tan.shaopeng@jp.fujitsu.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®