From: Fenghua Yu <fenghua.yu@intel.com>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v6 2/6] selftests/resctrl: Change the default limited time to 120 seconds
Date: Fri, 18 Mar 2022 15:48:50 -0700 [thread overview]
Message-ID: <YjUMUs7oIFXsjezq@otcwcpicx3.sc.intel.com> (raw)
In-Reply-To: <20220318075807.2921063-3-tan.shaopeng@jp.fujitsu.com>
On Fri, Mar 18, 2022 at 04:58:03PM +0900, Shaopeng Tan wrote:
> When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl
> selftests fail due to timeout after exceeding the default time limit of
> 45 seconds. On this system the test takes about 68 seconds.
> Since the failing test by default accesses a fixed size of memory, the
> execution time should not vary significantly between different environment.
> A new default of 120 seconds should be sufficient yet easy to customize
> with the introduction of the "settings" file for reference.
>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
> tools/testing/selftests/resctrl/settings | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 tools/testing/selftests/resctrl/settings
>
> diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings
> new file mode 100644
> index 000000000000..a383f3d4565b
> --- /dev/null
> +++ b/tools/testing/selftests/resctrl/settings
> @@ -0,0 +1,3 @@
> +# If running time is longer than 120 seconds when new tests are added in
> +# the future, increase timeout here.
> +timeout=120
> --
> 2.27.0
>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Thanks.
-Fenghua
next prev parent reply other threads:[~2022-03-18 22:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 7:58 [PATCH v6 0/6] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2022-03-18 7:58 ` [PATCH v6 1/6] selftests/resctrl: Kill child process before parent process terminates if SIGTERM is received Shaopeng Tan
2022-03-18 22:47 ` Fenghua Yu
2022-03-18 7:58 ` [PATCH v6 2/6] selftests/resctrl: Change the default limited time to 120 seconds Shaopeng Tan
2022-03-18 22:48 ` Fenghua Yu [this message]
2022-03-18 7:58 ` [PATCH v6 3/6] selftests/resctrl: Fix resctrl_tests' return code to work with selftest framework Shaopeng Tan
2022-03-18 20:58 ` Reinette Chatre
2022-03-18 22:51 ` Fenghua Yu
2022-03-18 7:58 ` [PATCH v6 4/6] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2022-03-18 20:59 ` Reinette Chatre
2022-03-18 22:55 ` Fenghua Yu
2022-03-18 7:58 ` [PATCH v6 5/6] selftests/resctrl: Update README about using kselftest framework to build/run resctrl_tests Shaopeng Tan
2022-03-18 20:59 ` Reinette Chatre
2022-03-18 22:57 ` Fenghua Yu
2022-03-18 7:58 ` [PATCH v6 6/6] selftests/resctrl: Add missing SPDX license to Makefile Shaopeng Tan
2022-03-18 21:00 ` Reinette Chatre
2022-03-18 22:58 ` Fenghua Yu
2022-03-18 21:00 ` [PATCH v6 0/6] selftests/resctrl: Add resctrl_tests into kselftest set Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjUMUs7oIFXsjezq@otcwcpicx3.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®