* [PATCH] hwmon: (dell-smm) Add Inspiron 3505 to fan type blacklist
@ 2022-03-18 18:34 Armin Wolf
2022-03-18 22:12 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Armin Wolf @ 2022-03-18 18:34 UTC (permalink / raw)
To: pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
Sadly, while firmware 1.5 fixed temperature labels on my
Inspiron 3505, it also caused fan type calls to take
ca. 4 seconds with the fan being at full speed.
Fix the resulting delays by adding the model to the
blacklist.
Tested on a Dell Inspiron 3505.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index a14e810f5598..c34342253d6e 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1165,6 +1165,13 @@ static const struct dmi_system_id i8k_blacklist_fan_type_dmi_table[] __initconst
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Inspiron 580 "),
},
},
+ {
+ .ident = "Dell Inspiron 3505",
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Inspiron 3505"),
+ },
+ },
{ }
};
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (dell-smm) Add Inspiron 3505 to fan type blacklist
2022-03-18 18:34 [PATCH] hwmon: (dell-smm) Add Inspiron 3505 to fan type blacklist Armin Wolf
@ 2022-03-18 22:12 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-03-18 22:12 UTC (permalink / raw)
To: Armin Wolf; +Cc: pali, jdelvare, linux-hwmon, linux-kernel
On Fri, Mar 18, 2022 at 07:34:08PM +0100, Armin Wolf wrote:
> Sadly, while firmware 1.5 fixed temperature labels on my
> Inspiron 3505, it also caused fan type calls to take
> ca. 4 seconds with the fan being at full speed.
> Fix the resulting delays by adding the model to the
> blacklist.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index a14e810f5598..c34342253d6e 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1165,6 +1165,13 @@ static const struct dmi_system_id i8k_blacklist_fan_type_dmi_table[] __initconst
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Inspiron 580 "),
> },
> },
> + {
> + .ident = "Dell Inspiron 3505",
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Inspiron 3505"),
> + },
> + },
> { }
> };
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 18:34 [PATCH] hwmon: (dell-smm) Add Inspiron 3505 to fan type blacklist Armin Wolf
2022-03-18 22:12 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®