mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Yinan Zhang <zhangyinan2019@email.szu.edu.cn>
Cc: Sean Anderson <seanga2@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/vm/page_owner_sort.c: add switch between culling by stacktrace and txt
Date: Thu, 24 Mar 2022 16:15:15 -0700	[thread overview]
Message-ID: <20220324161515.19e74f062210861d71ac414b@linux-foundation.org> (raw)
In-Reply-To: <623bc151.1c69fb81.12d57.ef3cSMTPIN_ADDED_BROKEN@mx.google.com>

On Thu, 24 Mar 2022 08:54:34 +0800 Yinan Zhang <zhangyinan2019@email.szu.edu.cn> wrote:

> on 2022/3/24 3:08, Andrew Morton wrote:
> > On Wed, 23 Mar 2022 10:05:28 +0800 Yinan Zhang<zhangyinan2019@email.szu.edu.cn>  wrote:
> >
> >>>> *(&list[i].txt+offset)) != 0) {
> >>>>                list2[count++] = list[i];
> >>>>            } else {
> >>>>                list2[count-1].num += list[i].num;
> >>>>
> >>>
> >> You are right. Due to timestamp etc, it's almost impossible to
> >>
> >> cull by txt. And I did observe some blocks differ in head and same in
> >>
> >> stack trace on my linux. The examples I mentioned in patch are
> >>
> >> part of them.
> >>
> >>
> >> Besides, --cull has been added in patch:
> >>
> >> tools/vm/page_owner_sort.c: support for user-defined culling rules
> >>
> > So should I drop this patch?
> 
> you decide.

I'd rather not.

And dropping this patch makes a huge mess of the series.  So I either
ask for the whole series to be redone and we might miss the merge
window or I send it all in as-is.

Sigh.  I'll send it all in as-is.  Please continue to work on this
issue and if we decide to drop the -c option, please send along a patch
to remove it over the next week or two.


      parent reply	other threads:[~2022-03-24 23:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 14:56 Yinan Zhang
2021-11-30  2:23 ` Sean Anderson
2022-03-21 20:38   ` Andrew Morton
     [not found]     ` <623932d3.1c69fb81.e3278.ab09SMTPIN_ADDED_BROKEN@mx.google.com>
2022-03-22  3:55       ` Sean Anderson
2022-03-22 18:03         ` Andrew Morton
     [not found]     ` <623932d7.1c69fb81.31089.1923SMTPIN_ADDED_BROKEN@mx.google.com>
2022-03-22 18:00       ` Andrew Morton
     [not found]   ` <623a8074.1c69fb81.33a39.0d6cSMTPIN_ADDED_BROKEN@mx.google.com>
2022-03-23 19:08     ` Andrew Morton
     [not found]       ` <623bc151.1c69fb81.12d57.ef3cSMTPIN_ADDED_BROKEN@mx.google.com>
2022-03-24 23:15         ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324161515.19e74f062210861d71ac414b@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanga2@gmail.com \
    --cc=zhangyinan2019@email.szu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®