From: "Clément Léger" <clement.leger@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Allan Nielsen" <allan.nielsen@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Clément Léger" <clement.leger@bootlin.com>
Subject: [net-next 3/5] net: mdiobus: fwnode: avoid calling of_* functions with non OF nodes
Date: Fri, 25 Mar 2022 18:22:32 +0100 [thread overview]
Message-ID: <20220325172234.1259667-4-clement.leger@bootlin.com> (raw)
In-Reply-To: <20220325172234.1259667-1-clement.leger@bootlin.com>
Without this check, of_parse_phandle_with_fixed_args() will be called
with whatever the type of the node. Use !is_of_node() which will work
for all node types supported by the fwnode API (ACPI, software nodes).
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
drivers/net/mdio/fwnode_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
index f9ec3818041a..7f71c0700c55 100644
--- a/drivers/net/mdio/fwnode_mdio.c
+++ b/drivers/net/mdio/fwnode_mdio.c
@@ -22,7 +22,7 @@ fwnode_find_mii_timestamper(struct fwnode_handle *fwnode)
struct of_phandle_args arg;
int err;
- if (is_acpi_node(fwnode))
+ if (!is_of_node(fwnode))
return NULL;
err = of_parse_phandle_with_fixed_args(to_of_node(fwnode),
--
2.34.1
next prev parent reply other threads:[~2022-03-25 19:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 17:22 [net-next 0/5] add fwnode based mdiobus registration Clément Léger
2022-03-25 17:22 ` [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus_register() Clément Léger
2022-03-25 18:38 ` Andrew Lunn
2022-03-28 6:26 ` Clément Léger
2022-03-28 13:03 ` Andrew Lunn
2022-03-28 13:27 ` Clément Léger
2022-03-28 14:12 ` Andrew Lunn
2022-03-28 14:41 ` Clément Léger
2022-03-26 2:52 ` kernel test robot
2022-03-26 2:52 ` kernel test robot
2022-03-25 17:22 ` [net-next 2/5] net: mdio: of: use fwnode_mdiobus_* functions Clément Léger
2022-03-25 18:32 ` Andrew Lunn
2022-03-28 7:53 ` Clément Léger
2022-03-25 17:22 ` Clément Léger [this message]
2022-03-25 17:22 ` [net-next 4/5] net: mdiobus: fwnode: allow phy device registration with non OF nodes Clément Léger
2022-03-25 17:22 ` [net-next 5/5] net: mdio: mscc-miim: use fwnode_mdiobus_register() Clément Léger
2022-03-26 2:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325172234.1259667-4-clement.leger@bootlin.com \
--to=clement.leger@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®