From: Andrew Lunn <andrew@lunn.ch>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Allan Nielsen <allan.nielsen@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next 2/5] net: mdio: of: use fwnode_mdiobus_* functions
Date: Fri, 25 Mar 2022 19:32:45 +0100 [thread overview]
Message-ID: <Yj4KzQPeVUxZEn0k@lunn.ch> (raw)
In-Reply-To: <20220325172234.1259667-3-clement.leger@bootlin.com>
On Fri, Mar 25, 2022 at 06:22:31PM +0100, Clément Léger wrote:
> Now that fwnode support has been added and implements the same behavior
> expected by device-tree parsing
The problem is, we cannot actually see that. There is no side by side
comparison which makes it clear it has the same behaviour.
Please see if something like this will work:
1/4: copy drivers/net/mdio/of_mdio.c to drivers/net/mdio/fwnode_mdio.c
2/4: Delete from fwnode_mdio.c the bits you don't need, like the whitelist
3/4: modify what is left of fwnode_mdio.c to actually use fwnode.
4/4: Rework of_mdio.c to use the code in fwnode_mdio.c
The 3/4 should make it clear it has the same behaviour, because we can
see what you have actually changed.
FYI: net-next is closed at the moment, so you need to post RFC
patches.
Andrew
next prev parent reply other threads:[~2022-03-25 19:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 17:22 [net-next 0/5] add fwnode based mdiobus registration Clément Léger
2022-03-25 17:22 ` [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus_register() Clément Léger
2022-03-25 18:38 ` Andrew Lunn
2022-03-28 6:26 ` Clément Léger
2022-03-28 13:03 ` Andrew Lunn
2022-03-28 13:27 ` Clément Léger
2022-03-28 14:12 ` Andrew Lunn
2022-03-28 14:41 ` Clément Léger
2022-03-26 2:52 ` kernel test robot
2022-03-26 2:52 ` kernel test robot
2022-03-25 17:22 ` [net-next 2/5] net: mdio: of: use fwnode_mdiobus_* functions Clément Léger
2022-03-25 18:32 ` Andrew Lunn [this message]
2022-03-28 7:53 ` Clément Léger
2022-03-25 17:22 ` [net-next 3/5] net: mdiobus: fwnode: avoid calling of_* functions with non OF nodes Clément Léger
2022-03-25 17:22 ` [net-next 4/5] net: mdiobus: fwnode: allow phy device registration " Clément Léger
2022-03-25 17:22 ` [net-next 5/5] net: mdio: mscc-miim: use fwnode_mdiobus_register() Clément Léger
2022-03-26 2:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj4KzQPeVUxZEn0k@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®