mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
	John Allen <john.allen@amd.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>
Cc: open list <linux-kernel@vger.kernel.org>,
	"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER" 
	<linux-crypto@vger.kernel.org>,
	Kerneis Gabriel <Gabriel.Kerneis@ssi.gouv.fr>,
	Richard Hughes <hughsient@gmail.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v3 3/4] crypto: ccp: Allow PSP driver to load without SEV/TEE support
Date: Thu, 31 Mar 2022 16:12:12 -0500	[thread overview]
Message-ID: <20220331211213.2844-4-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220331211213.2844-1-mario.limonciello@amd.com>

Previously the PSP probe routine would fail if both SEV and TEE were
missing.  This is possibly the case for some client parts.

As capabilities can now be accessed from userspace, it may still be
useful to have the PSP driver finish loading so that those capabilities
can be read.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2->v3:
 * Remove helper function, and still set up IRQs even in this case to keep
   cleanup process the same
v1->v2:
 * Whitespace fixes
---
 drivers/crypto/ccp/psp-dev.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
index 8cd404121cd5..a3b7b5130be4 100644
--- a/drivers/crypto/ccp/psp-dev.c
+++ b/drivers/crypto/ccp/psp-dev.c
@@ -99,18 +99,6 @@ static int psp_check_tee_support(struct psp_device *psp)
 	return 0;
 }
 
-static int psp_check_support(struct psp_device *psp)
-{
-	int sev_support = psp_check_sev_support(psp);
-	int tee_support = psp_check_tee_support(psp);
-
-	/* Return error if device neither supports SEV nor TEE */
-	if (sev_support && tee_support)
-		return -ENODEV;
-
-	return 0;
-}
-
 static int psp_init(struct psp_device *psp)
 {
 	int ret;
@@ -156,10 +144,6 @@ int psp_dev_init(struct sp_device *sp)
 	if (ret)
 		goto e_disable;
 
-	ret = psp_check_support(psp);
-	if (ret)
-		goto e_disable;
-
 	/* Disable and clear interrupts until ready */
 	iowrite32(0, psp->io_regs + psp->vdata->inten_reg);
 	iowrite32(-1, psp->io_regs + psp->vdata->intsts_reg);
-- 
2.34.1


  parent reply	other threads:[~2022-03-31 21:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 21:12 [PATCH v3 0/4] Export PSP security attributes Mario Limonciello
2022-03-31 21:12 ` [PATCH v3 1/4] crypto: ccp: cache capability into psp device Mario Limonciello
2022-03-31 21:12 ` [PATCH v3 2/4] crypto: ccp: Export PSP security bits to userspace Mario Limonciello
2022-03-31 21:12 ` Mario Limonciello [this message]
2022-04-05 21:05   ` [PATCH v3 3/4] crypto: ccp: Allow PSP driver to load without SEV/TEE support Tom Lendacky
2022-03-31 21:12 ` [PATCH v3 4/4] crypto: ccp: When TSME and SME both detected notify user Mario Limonciello
2022-04-05 21:06   ` Tom Lendacky
2022-04-08  8:32 ` [PATCH v3 0/4] Export PSP security attributes Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220331211213.2844-4-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Gabriel.Kerneis@ssi.gouv.fr \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=hughsient@gmail.com \
    --cc=john.allen@amd.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®