From: Mario Limonciello <mario.limonciello@amd.com>
To: Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>
Cc: open list <linux-kernel@vger.kernel.org>,
"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER"
<linux-crypto@vger.kernel.org>,
Kerneis Gabriel <Gabriel.Kerneis@ssi.gouv.fr>,
Richard Hughes <hughsient@gmail.com>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: [PATCH v3 4/4] crypto: ccp: When TSME and SME both detected notify user
Date: Thu, 31 Mar 2022 16:12:13 -0500 [thread overview]
Message-ID: <20220331211213.2844-5-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220331211213.2844-1-mario.limonciello@amd.com>
CC_ATTR_HOST_MEM_ENCRYPT is used to relay that memory encryption has been
activated by the kernel.
As it's technically possible to enable both SME and TSME at the same time,
detect this scenario and notify the user that enabling TSME and SME at the
same time is unnecessary.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2->v3:
* Remove extra whitespace
* Reword comment
v1->v2:
* Reword notice about TSME/SME
* Use cc_platform_has instead
---
drivers/crypto/ccp/psp-dev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
index a3b7b5130be4..c9c741ac8442 100644
--- a/drivers/crypto/ccp/psp-dev.c
+++ b/drivers/crypto/ccp/psp-dev.c
@@ -74,6 +74,12 @@ static unsigned int psp_get_capability(struct psp_device *psp)
}
psp->capability = val;
+ /* Detect if TSME and SME are both enabled */
+ if (psp->capability & PSP_CAPABILITY_PSP_SECURITY_REPORTING &&
+ psp->capability & (PSP_SECURITY_TSME_STATUS << PSP_CAPABILITY_PSP_SECURITY_OFFSET) &&
+ cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT))
+ dev_notice(psp->dev, "psp: Both TSME and SME are active, SME is unnecessary when TSME is active.\n");
+
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2022-03-31 21:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:12 [PATCH v3 0/4] Export PSP security attributes Mario Limonciello
2022-03-31 21:12 ` [PATCH v3 1/4] crypto: ccp: cache capability into psp device Mario Limonciello
2022-03-31 21:12 ` [PATCH v3 2/4] crypto: ccp: Export PSP security bits to userspace Mario Limonciello
2022-03-31 21:12 ` [PATCH v3 3/4] crypto: ccp: Allow PSP driver to load without SEV/TEE support Mario Limonciello
2022-04-05 21:05 ` Tom Lendacky
2022-03-31 21:12 ` Mario Limonciello [this message]
2022-04-05 21:06 ` [PATCH v3 4/4] crypto: ccp: When TSME and SME both detected notify user Tom Lendacky
2022-04-08 8:32 ` [PATCH v3 0/4] Export PSP security attributes Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331211213.2844-5-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Gabriel.Kerneis@ssi.gouv.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hughsient@gmail.com \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®