From: Jakob Koschel <jakobkoschel@gmail.com>
To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Yang Yingliang <yangyingliang@huawei.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Mike Rapoport <rppt@kernel.org>,
"Brian Johannesmeyer" <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>,
Jakob Koschel <jakobkoschel@gmail.com>
Subject: [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with dedicated list iterator variable
Date: Thu, 31 Mar 2022 23:50:03 +0200 [thread overview]
Message-ID: <20220331215003.882143-3-jakobkoschel@gmail.com> (raw)
In-Reply-To: <20220331215003.882143-1-jakobkoschel@gmail.com>
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.
To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].
This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.
Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
---
drivers/misc/atmel-ssc.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index d6cd5537126c..343e25555fbb 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -25,25 +25,24 @@ static LIST_HEAD(ssc_list);
struct ssc_device *ssc_request(unsigned int ssc_num)
{
- int ssc_valid = 0;
- struct ssc_device *ssc;
+ struct ssc_device *ssc = NULL, *iter;
mutex_lock(&user_lock);
- list_for_each_entry(ssc, &ssc_list, list) {
- if (ssc->pdev->dev.of_node) {
- if (of_alias_get_id(ssc->pdev->dev.of_node, "ssc")
+ list_for_each_entry(iter, &ssc_list, list) {
+ if (iter->pdev->dev.of_node) {
+ if (of_alias_get_id(iter->pdev->dev.of_node, "ssc")
== ssc_num) {
- ssc->pdev->id = ssc_num;
- ssc_valid = 1;
+ iter->pdev->id = ssc_num;
+ ssc = iter;
break;
}
- } else if (ssc->pdev->id == ssc_num) {
- ssc_valid = 1;
+ } else if (iter->pdev->id == ssc_num) {
+ ssc = iter;
break;
}
}
- if (!ssc_valid) {
+ if (!ssc) {
mutex_unlock(&user_lock);
pr_err("ssc: ssc%d platform device is missing\n", ssc_num);
return ERR_PTR(-ENODEV);
--
2.25.1
next prev parent reply other threads:[~2022-03-31 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:50 [PATCH 1/3] ASoC: Intel: catpt: remove check of list iterator against head past the loop body Jakob Koschel
2022-03-31 21:50 ` [PATCH 2/3] ASoC: sprd: " Jakob Koschel
2022-04-01 2:12 ` Baolin Wang
2022-03-31 21:50 ` Jakob Koschel [this message]
2022-04-05 6:44 ` [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with dedicated list iterator variable Codrin.Ciubotariu
2022-04-01 7:00 ` [PATCH 1/3] ASoC: Intel: catpt: remove check of list iterator against head past the loop body Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331215003.882143-3-jakobkoschel@gmail.com \
--to=jakobkoschel@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=bjohannesmeyer@gmail.com \
--cc=broonie@kernel.org \
--cc=c.giuffrida@vu.nl \
--cc=cezary.rojewski@intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=codrin.ciubotariu@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=h.j.bos@vu.nl \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rppt@kernel.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®